refactor: fetch config from /api/config (nginx-served)

- Update ConfigService to fetch from /api/config instead of /config.json
- Remove unused Helm env vars from values.yaml and values-prod.yaml
- Angular apps don't read container env vars, config comes from /api/config

Config served by nginx from rproxy-config ConfigMap.

Author: danieltruong

helm/eagle-admin/values-prod.yaml

@@ -21,13 +21,7 @@ podDisruptionBudget:
   minAvailable: 1
 
 # Mount existing ConfigMap for env.js
-# IMPORTANT: ConfigMap should only contain configEndpoint=true and KEYCLOAK_CLIENT_ID
-# All other config comes from /api/config. See wiki: Configuration-Management
+# Contains configEndpoint=true and KEYCLOAK_CLIENT_ID
+# All other config comes from /api/config (served by nginx from rproxy-config ConfigMap)
 envJs:
   configMap: "eagle-admin-env-js"
-
-env:
-  DEPLOYMENT_ENVIRONMENT: "prod"
-  BANNER_COLOUR: ""
-  REMOTE_API_PATH: "https://projects.eao.gov.bc.ca/api"
-  REMOTE_PUBLIC_PATH: "https://projects.eao.gov.bc.ca/"

helm/eagle-admin/values.yaml

@@ -52,20 +52,14 @@ probes:
     failureThreshold: 3
 
 # Environment variables passed to the container
-env:
-  RealIpFrom: "172.51.0.0/16"
-  AdditionalRealIpFromRules: ""
-  IpFilterRules: "#allow all; deny all;"
-  DEPLOYMENT_ENVIRONMENT: ""
-  BANNER_COLOUR: ""
-  REMOTE_API_PATH: ""
-  REMOTE_PUBLIC_PATH: ""
-  KEYCLOAK_CLIENT_ID: "eagle-admin-console"
+# Container environment variables (optional, not used by Angular)
+# Angular reads config from /api/config, not container env vars
+env: {}
 
 # env.js ConfigMap - mount external ConfigMap to override built-in env.js
 # Set configMap name to use existing ConfigMap, leave empty to use container's built-in env.js
-# IMPORTANT: Only set configEndpoint=true and KEYCLOAK_CLIENT_ID in this ConfigMap
-# All other config comes from /api/config. See wiki: Configuration-Management
+# ConfigMap should only contain: configEndpoint=true and KEYCLOAK_CLIENT_ID
+# All other config fetched at runtime from /api/config (served by nginx from rproxy-config)
 envJs:
   configMap: ""  # e.g., "eagle-admin-env-js"
 

src/app/services/config.service.ts

@@ -122,8 +122,9 @@ export class ConfigService {
   }
 
   /**
-   * Fetch configuration from nginx-served JSON.
+   * Fetch configuration from /api/config.
    * Only called when configEndpoint=true (deployed environments).
+   * nginx serves this from ConfigMap (no eagle-api dependency).
    * Retries with fibonacci backoff, times out to prevent blocking.
    */
   private async getConfigFromApi(): Promise<EnvConfig> {
@@ -135,10 +136,10 @@ export class ConfigService {
 
     while (attempts < maxAttempts) {
       try {
-        // Fetch config from nginx-served ConfigMap JSON
-        // No Authorization header needed - public static file
+        // Fetch config from nginx-served ConfigMap
+        // No Authorization header needed - public endpoint
         const response = await firstValueFrom(
-          this.httpClient.get<EnvConfig>('/config.json', { observe: 'response' })
+          this.httpClient.get<EnvConfig>('/api/config', { observe: 'response' })
             .pipe(timeout(requestTimeoutMs))
         );
         return response.body || {};
@@ -155,7 +156,7 @@ export class ConfigService {
         n2 = delay;
       }
     }
-    throw new Error('Failed to load config from /config.json');
+    throw new Error('Failed to load config from /api/config');
   }
 
   private delay(ms: number): Promise<void> {