Pr comments.

Author: devinleighsmith

api/Infrastructure/Authentication/KeycloakTokenService.cs

@@ -64,13 +64,13 @@ public async Task<string> GetServiceAccountTokenAsync(KeycloakClientOptions opti
                 var token = await RequestServiceAccountTokenAsync(options, cancellationToken);
                 var cacheDuration = GetCacheDuration(token.ExpiresAt, options.RefreshSkewSeconds);
 
-                if (cacheDuration.Seconds <= options.RefreshSkewSeconds)
+                if (cacheDuration.TotalSeconds > options.RefreshSkewSeconds)
                 {
                     _cache.Set(cacheKey, token, cacheDuration);
                 }
                 else
                 {
-                    _logger.LogWarning("Unable to set valid cache duration, below skew thereshold.");
+                    _logger.LogWarning("Unable to set valid cache duration, below skew threshold.");
                 }
 
 
@@ -110,8 +110,8 @@ private async Task<ServiceAccountToken> RequestServiceAccountTokenAsync(
             if (response.IsError || string.IsNullOrWhiteSpace(response.AccessToken))
             {
                 _logger.LogError(
-                    "Failed to retrieve Keycloak service account token. Error: {Error}.",
-                    response.Error ?? "unknown");
+                    "Failed to retrieve Keycloak service account token. Error: {Error}. Description: {ErrorDescription}",
+                    response.Error ?? "unknown", response.ErrorDescription);
                 throw new InvalidOperationException("Unable to retrieve service account token from Keycloak.");
             }
 

api/Infrastructure/Options/KeycloakClientOptions.cs

@@ -28,6 +28,7 @@ public sealed class KeycloakClientOptions
         /// <summary>
         /// Service account secret used to retrieve tokens. Value is expected from environment variables.
         /// </summary>
+        [Required]
         public string ServiceAccountSecret { get; set; } = default!;
 
         /// <summary>

cso-client/CsoClient.cs

@@ -59,10 +59,9 @@ public async Task<bool> SendOrderAsync(OrderActionDto order, CancellationToken c
                 : await response.Content.ReadAsStringAsync(cancellationToken);
 
             _logger.LogWarning(
-                "CSO order submit failed with status {StatusCode} {ReasonPhrase}. Response: {ResponseBody}",
+                "CSO order submit failed with status {StatusCode} {ReasonPhrase}.",
                 (int)response.StatusCode,
-                response.ReasonPhrase,
-                body);
+                response.ReasonPhrase);
         }
 
         return response.IsSuccessStatusCode;