Make outbound proxy configurable in settings and eliminate duplicate proxy class

Author: bferguso

.github/github_settings.py

@@ -617,9 +617,22 @@ def get_env_variable(var_name, default=None):
 # This is the default if source isn't set as a parameter in the request
 TILESERVER_URL = "https://openmaps.gov.bc.ca/"
 BC_TILESERVER_URLS = {
-    "maps": "https://maps.gov.bc.ca/",
-    "openmaps": TILESERVER_URL,
-    "local": "http://localhost:7800/",
+    "maps": {
+        "url": "https://maps.gov.bc.ca/",
+        "use_outbound_proxy": True,  # Use outbound proxy for this source
+    },
+    "openmaps": {
+        "url": TILESERVER_URL,
+        "use_outbound_proxy": True,  # Use outbound proxy for this source
+    },
+    "local": {
+        "url": get_env_variable("TILESERVER_LOCAL_URL"),
+        "use_outbound_proxy": False,  # Local doesn't need outbound proxy
+    },
+    "local-feature": {
+        "url": get_env_variable("FEATURESERVER_LOCAL_URL"),
+        "use_outbound_proxy": False,  # Local doesn't need outbound proxy
+    },
 }
 
 AUTH_BYPASS_HOSTS = get_env_variable("AUTH_BYPASS_HOSTS", default="localhost")

bcap/settings.py

@@ -699,10 +699,22 @@ def get_env_variable(var_name, is_optional=False):
 # This is the default if source isn't set as a parameter in the request
 TILESERVER_URL = "https://openmaps.gov.bc.ca/"
 BC_TILESERVER_URLS = {
-    "maps": "https://maps.gov.bc.ca/",
-    "openmaps": TILESERVER_URL,
-    "local": get_env_variable("TILESERVER_LOCAL_URL"),
-    "local-feature": get_env_variable("FEATURESERVER_LOCAL_URL"),
+    "maps": {
+        "url": "https://maps.gov.bc.ca/",
+        "use_outbound_proxy": True  # Use outbound proxy for this source
+    },
+    "openmaps": {
+        "url": TILESERVER_URL,
+        "use_outbound_proxy": True  # Don't use outbound proxy for this source
+    },
+    "local": {
+        "url": get_env_variable("TILESERVER_LOCAL_URL"),
+        "use_outbound_proxy": False  # Local doesn't need outbound proxy
+    },
+    "local-feature": {
+        "url": get_env_variable("FEATURESERVER_LOCAL_URL"),
+        "use_outbound_proxy": False  # Local doesn't need outbound proxy
+    },
 }
 
 AUTH_BYPASS_HOSTS = get_env_variable("AUTH_BYPASS_HOSTS")

bcap/urls.py

@@ -14,7 +14,7 @@
     TranslateToResourceTypeView,
 )
 from bcap.views.resource import ResourceReportView, ResourceEditLogView
-from bcgov_arches_common.views.map import BCTileserverProxyView, BCTileserverLocalProxyView
+from bcgov_arches_common.views.map import BCTileserverProxyView
 
 uuid_regex = settings.UUID_REGEX
 
@@ -39,16 +39,6 @@
         BCTileserverProxyView.as_view(),
         name="bcap_tile_server",
     ),
-    path(
-        f"{PREFIX}bclocaltileserver/",
-        BCTileserverLocalProxyView.as_view(),
-        name="bcap_local_tile_server_root",
-    ),
-    path(
-        f"{PREFIX}bclocaltileserver/<path:path>",
-        BCTileserverLocalProxyView.as_view(),
-        name="bcap_local_tile_server",
-    ),
     path(
         f"{PREFIX}borden_number/<uuid:resourceinstanceid>",
         BordenNumber.as_view(),