fix: #792 FOM Dashboard Gap Adjustment. (#848)

ianliuwk1019 · web-flow · commit dcfee43c1fb2 · 2025-09-23T10:09:43.000-07:00
diff --git a/admin/src/app/analytics-dashboard/analytics-dashboard.component.html b/admin/src/app/analytics-dashboard/analytics-dashboard.component.html
@@ -1,8 +1,7 @@
-<form #alyticsForm="ngForm">
   <div class="top-container" style="overflow-y: hidden;">
     <div class="container">
       <div class="title-container">
-          <div>
+          <form #alyticsForm="ngForm">
             <!-- Page title and subtitle-->
             <div>
               <h1 class="text-muted mb-0">Dashboard</h1>
@@ -74,12 +73,12 @@ <h1 class="text-muted mb-0">Dashboard</h1>
                 </select>
               </div>
             </div>
-          </div>
+          </form>
       </div>
     </div>
   </div>
 
-  <div class="bottom-container scroll">
+  <div class="bottom-container">
     <!-- Public Engagement Overview -->
     <div class="container pb-0" id="public-engagement-overview">
       <div class="row"><p>Public Engagement Overview</p></div>
@@ -187,5 +186,4 @@ <h1 class="text-muted mb-0">Dashboard</h1>
           ></apx-chart>
         </div>
       </div>
-  </div>
-</form>
+  </div>
diff --git a/admin/src/app/analytics-dashboard/analytics-dashboard.component.scss b/admin/src/app/analytics-dashboard/analytics-dashboard.component.scss
@@ -47,12 +47,8 @@ $stats-blue-1: #123B64;
 
 // --- Bottom Container
 .bottom-container {
-  &.scroll {
-    // Show vertical scrollbar only when content overflows viewport
+  // Show vertical scrollbar only when content overflows viewport
     overflow-y: auto;
-    // height: 65.45vh; // TODO: need to dynamically calculate this.
-    height: 58.45vh; // TODO: need to dynamically calculate this.
-  }
 }
 
 // --- chart styling
diff --git a/admin/src/app/analytics-dashboard/analytics-dashboard.component.ts b/admin/src/app/analytics-dashboard/analytics-dashboard.component.ts
@@ -244,7 +244,7 @@ export class AnalyticsDashboardComponent implements OnInit, AfterViewInit {
         },
         chart: {
           // Horizontal bar chart dynamic height adjustment
-          height: Math.max(260, apiData.length * 50)
+          height: Math.max(260, data.length * 50)
         }
       });
     }
diff --git a/admin/src/index.html b/admin/src/index.html
@@ -18,15 +18,6 @@
 			<div class="spinner-new rotating"></div>
 		</div>
 	</app-root>
-
-	...
-...
-<body>
-  <app-root></app-root>
-
-</body>
-...
-...
 </body>
 
 </html>

Original file line number	Diff line number	Diff line change
`@@ -244,7 +244,7 @@ export class AnalyticsDashboardComponent implements OnInit, AfterViewInit {`
`244`	`244`	`},`
`245`	`245`	`chart: {`
`246`	`246`	`// Horizontal bar chart dynamic height adjustment`
`247`		`- height: Math.max(260, apiData.length * 50)`
	`247`	`+ height: Math.max(260, data.length * 50)`
`248`	`248`	`}`
`249`	`249`	`});`
`250`	`250`	`}`