test(unit): improve code coverage on fringe edge cases

Signed-off-by: Jeremy Ho <jujaga@gmail.com>

Author: jujaga

tests/unit/app.test.ts

@@ -56,6 +56,23 @@ describe('App', () => {
     expect(response.status).toBe(404);
   });
 
+  it('should return 429 when rate limit is exceeded', async () => {
+    vi.resetModules();
+    vi.stubEnv('APP_RATEENABLE', 'true');
+    vi.stubEnv('APP_RATELIMIT', '1');
+
+    const { app: rateLimitedApp } = await import('../../src/app.ts');
+
+    // First request consumes the limit
+    await request(rateLimitedApp).get('/');
+
+    const response = await request(rateLimitedApp).get('/');
+    expect(response.status).toBe(429);
+    expect((response.body as { detail: string }).detail).toBe('Too many requests, please try again later.');
+    vi.unstubAllEnvs();
+    vi.doUnmock('../../src/db/index.ts');
+  });
+
   describe('errorHandler', () => {
     let req: Request;
     let res: Response;

tests/unit/db/utils.test.ts

@@ -3,6 +3,7 @@ import { mockSqlExecuteReturn } from './kysely.helper.ts'; // Must be imported b
 import { Kysely, sql } from 'kysely';
 
 import {
+  SYSTEM_USER,
   createAuditLogTrigger,
   createIndex,
   createUpdatedAtTrigger,
@@ -120,15 +121,33 @@ describe('DB Utils', () => {
   });
 
   it('should add timestamps to a table builder', () => {
+    const colBuilder = {
+      defaultTo: vi.fn().mockReturnThis(),
+      notNull: vi.fn().mockReturnThis()
+    };
     const tableBuilder = {
       addColumn: vi.fn().mockReturnThis()
     } as unknown as CreateTableBuilder<string>;
     const result = withTimestamps(tableBuilder);
 
     // eslint-disable-next-line @typescript-eslint/unbound-method
     expect(result.addColumn).toHaveBeenCalledWith('created_at', 'timestamptz', expect.any(Function));
+    const createdAtFn = (tableBuilder.addColumn as Mock).mock.calls.find((call) => call[0] === 'created_at')?.[2] as (
+      col: typeof colBuilder
+    ) => void;
+    createdAtFn(colBuilder);
+    expect(colBuilder.notNull).toHaveBeenCalled();
+    expect(colBuilder.defaultTo).toHaveBeenCalledWith(expect.objectContaining({ strings: ['CURRENT_TIMESTAMP'] }));
+
     // eslint-disable-next-line @typescript-eslint/unbound-method
     expect(result.addColumn).toHaveBeenCalledWith('created_by', 'text', expect.any(Function));
+    const createdByFn = (tableBuilder.addColumn as Mock).mock.calls.find((call) => call[0] === 'created_by')?.[2] as (
+      col: typeof colBuilder
+    ) => void;
+    createdByFn(colBuilder);
+    expect(colBuilder.notNull).toHaveBeenCalled();
+    expect(colBuilder.defaultTo).toHaveBeenCalledWith(SYSTEM_USER);
+
     // eslint-disable-next-line @typescript-eslint/unbound-method
     expect(result.addColumn).toHaveBeenCalledWith('updated_at', 'timestamptz');
     // eslint-disable-next-line @typescript-eslint/unbound-method

tests/unit/services/helpers/event.test.ts

@@ -6,41 +6,6 @@ import {
 
 import type { Event } from '../../../../src/types/index.d.ts';
 
-describe('mergeDateAndTimeToISOString', () => {
-  it('merges date and time (HH:mm) to ISO string in UTC', () => {
-    const date = new Date(Date.UTC(2023, 5, 1)); // 2023-06-01T00:00:00.000Z
-    const time = '14:30';
-    const result = mergeDateAndTimeToISOString(date, time);
-    expect(result).toBe('2023-06-01T14:30:00.000Z');
-  });
-
-  it('merges date and time (HH:mm:ss) to ISO string in UTC', () => {
-    const date = new Date(Date.UTC(2023, 5, 1));
-    const time = '14:30:15';
-    const result = mergeDateAndTimeToISOString(date, time);
-    expect(result).toBe('2023-06-01T14:30:15.000Z');
-  });
-
-  it('merges date and time (HH:mm:ss.sss) to ISO string in UTC', () => {
-    const date = new Date(Date.UTC(2023, 5, 1));
-    const time = '14:30:15.123';
-    const result = mergeDateAndTimeToISOString(date, time);
-    expect(result).toBe('2023-06-01T14:30:15.123Z');
-  });
-
-  it('ignores timezone offset in time string', () => {
-    const date = new Date(Date.UTC(2023, 5, 1));
-    const time = '14:30:15.123+02:00';
-    const result = mergeDateAndTimeToISOString(date, time);
-    expect(result).toBe('2023-06-01T14:30:15.123Z');
-  });
-
-  it('throws error for invalid time format', () => {
-    const date = new Date(Date.UTC(2023, 5, 1));
-    expect(() => mergeDateAndTimeToISOString(date, 'badtime')).toThrow();
-  });
-});
-
 describe('dateTimePartsToEvent', () => {
   it('returns start_datetime and end_datetime when times are provided', () => {
     const startDate = new Date(Date.UTC(2023, 5, 1));
@@ -149,3 +114,53 @@ describe('eventToDateTimeParts', () => {
     });
   });
 });
+
+describe('mergeDateAndTimeToISOString', () => {
+  it('merges date and time (HH:mm) to ISO string in UTC', () => {
+    const date = new Date(Date.UTC(2023, 5, 1)); // 2023-06-01T00:00:00.000Z
+    const time = '14:30';
+    const result = mergeDateAndTimeToISOString(date, time);
+    expect(result).toBe('2023-06-01T14:30:00.000Z');
+  });
+
+  it('merges date and time (HH:mm:ss) to ISO string in UTC', () => {
+    const date = new Date(Date.UTC(2023, 5, 1));
+    const time = '14:30:15';
+    const result = mergeDateAndTimeToISOString(date, time);
+    expect(result).toBe('2023-06-01T14:30:15.000Z');
+  });
+
+  it('merges date and time (HH:mm:ss.sss) to ISO string in UTC', () => {
+    const date = new Date(Date.UTC(2023, 5, 1));
+    const time = '14:30:15.123';
+    const result = mergeDateAndTimeToISOString(date, time);
+    expect(result).toBe('2023-06-01T14:30:15.123Z');
+  });
+
+  it('ignores timezone offset in time string', () => {
+    const date = new Date(Date.UTC(2023, 5, 1));
+    const time = '14:30:15.123+02:00';
+    const result = mergeDateAndTimeToISOString(date, time);
+    expect(result).toBe('2023-06-01T14:30:15.123Z');
+  });
+
+  it('throws error for invalid time format', () => {
+    const date = new Date(Date.UTC(2023, 5, 1));
+    expect(() => mergeDateAndTimeToISOString(date, 'badtime')).toThrow();
+  });
+
+  it('throws error for non-numeric hour', () => {
+    const date = new Date(Date.UTC(2023, 5, 1));
+    expect(() => mergeDateAndTimeToISOString(date, 'xx:30')).toThrow('Invalid numeric values in time: xx:30');
+  });
+
+  it('throws error for non-numeric minute', () => {
+    const date = new Date(Date.UTC(2023, 5, 1));
+    expect(() => mergeDateAndTimeToISOString(date, '14:xx')).toThrow('Invalid numeric values in time: 14:xx');
+  });
+
+  it('throws error for non-numeric second', () => {
+    const date = new Date(Date.UTC(2023, 5, 1));
+    expect(() => mergeDateAndTimeToISOString(date, '14:30:xx')).toThrow('Invalid numeric values in time: 14:30:xx');
+  });
+});