Various backend lint fixes #3

Author: kyle1morel

app/src/controllers/accessRequest.ts

@@ -9,7 +9,7 @@ import { getInitiative } from '../services/initiative.ts';
 import { createUser, readUser } from '../services/user.ts';
 import { assignGroup, getGroups, getSubjectGroups, removeGroup } from '../services/yars.ts';
 import { Problem } from '../utils/index.ts';
-import { AccessRequestStatus, GroupName, IdentityProvider, Initiative } from '../utils/enums/application.ts';
+import { AccessRequestStatus, GroupName, IdentityProvider } from '../utils/enums/application.ts';
 
 import type { Request, Response } from 'express';
 import type { PrismaTransactionClient } from '../db/dataConnection.ts';

app/src/controllers/electrificationProject.ts

@@ -48,6 +48,10 @@ import type {
 
 /**
  * Handles creating a project from intake data
+ * @param tx Prisma transaction client
+ * @param data Electrification project data
+ * @param currentContext context data of current request
+ * @returns Maniplated electrification data
  */
 const generateElectrificationProjectData = async (
   tx: PrismaTransactionClient,
@@ -60,7 +64,7 @@ const generateElectrificationProjectData = async (
   if (!activityId) {
     activityId = (await createActivity(tx, Initiative.ELECTRIFICATION, generateCreateStamps(currentContext)))
       ?.activityId;
-    const contacts = await searchContacts(tx, { userId: [currentContext.userId as string] });
+    const contacts = await searchContacts(tx, { userId: [currentContext.userId!] });
     if (contacts[0]) await createActivityContact(tx, activityId, contacts[0].contactId, ActivityContactRole.PRIMARY);
   }
 
@@ -98,6 +102,8 @@ const generateElectrificationProjectData = async (
 
 /**
  * Send an email with the confirmation of electrification project
+ * @param req Express Request object
+ * @param res Express Response object
  */
 export const emailElectrificationProjectConfirmationController = async (
   req: Request<never, never, Email>,
@@ -119,11 +125,9 @@ export const createElectrificationProjectController = async (
   res: Response
 ) => {
   // Provide an empty body if POST body is given undefined
-  if (req.body === undefined) {
-    req.body = {
-      project: {}
-    } as ElectrificationProjectIntake;
-  }
+  req.body ??= {
+    project: {}
+  } as ElectrificationProjectIntake;
 
   const result = await transactionWrapper<ElectrificationProject>(async (tx: PrismaTransactionClient) => {
     const electrificationProject = await generateElectrificationProjectData(tx, req.body, req.currentContext);

app/src/db/dataConnection.ts

@@ -7,12 +7,12 @@ import numericTransform from './extensions/numeric.ts';
 import projectIdTransform from './extensions/projectId.ts';
 
 const db = {
-  host: config.get('server.db.host'),
-  user: config.get('server.db.username'),
-  password: config.get('server.db.password'),
-  database: config.get('server.db.database'),
-  port: config.get('server.db.port'),
-  poolMax: config.get('server.db.poolMax')
+  host: config.get<string>('server.db.host'),
+  user: config.get<string>('server.db.username'),
+  password: config.get<string>('server.db.password'),
+  database: config.get<string>('server.db.database'),
+  port: config.get<string>('server.db.port'),
+  poolMax: config.get<string>('server.db.poolMax')
 };
 
 const datasourceUrl = `postgresql://${db.user}:${db.password}@${db.host}:${db.port}/${db.database}?&connection_limit=${db.poolMax}`;

app/src/db/migrations/20250107000000_019-contact-management.ts

@@ -1,4 +1,3 @@
-/* eslint-disable max-len */
 import type { Knex } from 'knex';
 
 import { Action, GroupName, Initiative, Resource } from '../../utils/enums/application.ts';