BE updated to remove isDevelopedInBC from types and validation

Signed-off-by: Sanjay Babu <sanjaytkbabu@gmail.com>

Author: sanjaytkbabu

app/src/controllers/housingProject.ts

@@ -114,7 +114,6 @@ const generateHousingProjectData = async (
     basic = {
       consentToFeedback: data.basic.consentToFeedback ?? false,
       projectApplicantType: data.basic.projectApplicantType,
-      isDevelopedInBc: data.basic.isDevelopedInBc,
       companyIdRegistered: data.basic.registeredId,
       companyNameRegistered: data.basic.registeredName
     };

app/src/db/prisma/schema.prisma

@@ -586,7 +586,6 @@ model housing_project {
   hasRentalUnits                  String?   @map("has_rental_units")
   projectDescription              String?   @map("project_description")
   projectApplicantType            String?   @map("project_applicant_type")
-  isDevelopedInBc                 String?   @map("is_developed_in_bc")
   multiFamilyUnits                String?   @map("multi_family_units")
   otherUnits                      String?   @map("other_units")
   otherUnitsDescription           String?   @map("other_units_description")

app/src/docs/v1.api-spec.yaml

@@ -2812,10 +2812,6 @@ components:
           enum: [Business, Individual]
           description: Are you applying as an individual or as a business?
           example: 'Business'
-        isDevelopedInBc:
-          type: string
-          description: Is the project developed in BC?
-          example: 'Yes'
         multiFamilyUnits:
           type: string
           description: Range of multi-family units in the project
@@ -3547,12 +3543,6 @@ components:
               enum: [Business, Individual]
               description: Are you applying as an individual or as a business?
               example: 'Business'
-            isDevelopedInBc:
-              type: boolean
-              description: >-
-                Indicates if the project is being developed in British Columbia
-                (BC)
-              example: true
             companyNameRegistered:
               type: string
               description: Name of the company associated with the project
@@ -3816,10 +3806,6 @@ components:
           type: string
           description: Name of the company connected to the project
           example: QW URBAN FOOD LTD.
-        isDevelopedInBc:
-          type: string
-          description: Is the project developed in BC?
-          example: 'Yes'
         projectName:
           type: string
           description: Name of the Project

app/src/types/stuff.d.ts

@@ -278,7 +278,6 @@ export type HousingProjectIntake = {
   basic: {
     consentToFeedback: boolean;
     projectApplicantType: string | null;
-    isDevelopedInBc: string | null;
     registeredId: string | null;
     registeredName: string | null;
   };

app/src/validators/basic.ts

@@ -1,6 +1,5 @@
 import Joi from 'joi';
 
-import { YES_NO_LIST } from '../utils/constants/application';
 import { PROJECT_APPLICANT_LIST } from '../utils/constants/housing';
 import { ENQUIRY_TYPE_LIST } from '../utils/constants/projectCommon';
 import { ProjectApplicant } from '../utils/enums/housing';
@@ -10,13 +9,6 @@ export const basicIntake = Joi.object({
   projectApplicantType: Joi.string()
     .required()
     .valid(...PROJECT_APPLICANT_LIST),
-  isDevelopedInBc: Joi.when('projectApplicantType', {
-    is: ProjectApplicant.BUSINESS,
-    then: Joi.string()
-      .required()
-      .valid(...YES_NO_LIST),
-    otherwise: Joi.string().allow(null)
-  }),
   registeredId: Joi.string().allow(null),
   registeredName: Joi.when('projectApplicantType', {
     is: ProjectApplicant.BUSINESS,

app/src/validators/housingProject.ts

@@ -9,7 +9,7 @@ import { contactSchema } from './contact';
 import { housing } from './housing';
 import { permits } from './permits';
 import { validate } from '../middleware/validation';
-import { YES_NO_LIST, YES_NO_UNSURE_LIST } from '../utils/constants/application';
+import { YES_NO_UNSURE_LIST } from '../utils/constants/application';
 import { NUM_RESIDENTIAL_UNITS_LIST } from '../utils/constants/housing';
 import { APPLICATION_STATUS_LIST, INTAKE_STATUS_LIST, SUBMISSION_TYPE_LIST } from '../utils/constants/projectCommon';
 import { BasicResponse } from '../utils/enums/application';
@@ -87,13 +87,6 @@ const schema = {
       submittedAt: Joi.string().required(),
       companyNameRegistered: Joi.string().allow(null),
       companyIdRegistered: Joi.string().allow(null),
-      isDevelopedInBc: Joi.when('companyNameRegistered', {
-        is: Joi.string().required(),
-        then: Joi.string()
-          .required()
-          .valid(...YES_NO_LIST),
-        otherwise: Joi.string().allow(null)
-      }),
       projectName: Joi.string().required(),
       projectDescription: Joi.string().allow(null),
       singleFamilyUnits: Joi.string()

app/tests/unit/data/index.ts

@@ -345,7 +345,6 @@ export const TEST_HOUSING_PROJECT_1: HousingProject = {
   hasRentalUnits: BasicResponse.NO,
   housingCoopDescription: null,
   indigenousDescription: null,
-  isDevelopedInBc: BasicResponse.YES,
   locality: 'Place',
   multiFamilyUnits: BasicResponse.NO,
   nonProfitDescription: null,
@@ -407,7 +406,6 @@ export const TEST_HOUSING_PROJECT_CREATE: HousingProject = {
   hasRentalUnits: BasicResponse.NO,
   housingCoopDescription: null,
   indigenousDescription: null,
-  isDevelopedInBc: BasicResponse.YES,
   locality: 'Place',
   multiFamilyUnits: BasicResponse.NO,
   nonProfitDescription: null,
@@ -434,7 +432,6 @@ export const TEST_HOUSING_PROJECT_INTAKE: HousingProjectIntake = {
   appliedPermits: [],
   basic: {
     consentToFeedback: false,
-    isDevelopedInBc: BasicResponse.YES,
     projectApplicantType: null,
     registeredId: 'FM0281610',
     registeredName: 'COMPANY'