Skip to content

Commit bb9ff78

Browse files
authored
26933 - Add loading overlay during refund view initialization (#251)
* add loading overlay during refund view initialization * 1.3.11 * tweaks * modify style * Hide $NAN until loaded
1 parent 87567fe commit bb9ff78

File tree

3 files changed

+18
-4
lines changed

3 files changed

+18
-4
lines changed

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "fas-ui",
3-
"version": "1.3.10",
3+
"version": "1.3.11",
44
"private": true,
55
"main": "./lib/lib.umd.min.js",
66
"appName": "FAS UI",

src/components/eft/ShortNameRefundView.vue

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,12 @@
33
id="shortname-details"
44
class="view-container"
55
>
6+
<v-overlay :value="isInitialLoading">
7+
<v-progress-circular
8+
indeterminate
9+
size="24"
10+
></v-progress-circular>
11+
</v-overlay>
612
<div class="view-header flex-column">
713
<h1 class="view-header__title">
814
Refund Information
@@ -50,7 +56,7 @@
5056
<v-col class="col-6 col-sm-3 font-weight-bold">
5157
Unsettled Amount on Short Name
5258
</v-col>
53-
<v-col class="pl-0">
59+
<v-col class="pl-0" v-show="!isInitialLoading">
5460
{{ formatCurrency(Number(shortNameDetails.creditsRemaining)) }}
5561
</v-col>
5662
</v-row>
@@ -67,6 +73,7 @@
6773
v-if="readOnly"
6874
data-test="refundAmountReadOnly"
6975
class="pl-0"
76+
v-show="!isInitialLoading"
7077
>
7178
{{ formatCurrency(Number(refundDetails.refundAmount)) }}
7279
</v-col>
@@ -79,6 +86,7 @@
7986
data-test="refundAmount"
8087
:rules="refundAmountRules"
8188
:disabled="isFormDisabled"
89+
v-show="!isInitialLoading"
8290
/>
8391
</v-row>
8492

@@ -430,6 +438,7 @@ export default defineComponent({
430438
const eftRefundAddressState = useEFTRefundAddress()
431439
const state = reactive({
432440
...eftRefundAddressState,
441+
isInitialLoading: true,
433442
entityName: undefined as string,
434443
shortNameDetails: {} as ShortNameDetails,
435444
refundDetails: {} as EFTRefund,
@@ -501,6 +510,7 @@ export default defineComponent({
501510
}
502511
503512
onMounted(async () => {
513+
state.isInitialLoading = true
504514
await loadShortnameDetails()
505515
if (props.shortNameId && props.eftRefundId) {
506516
state.readOnly = true
@@ -509,6 +519,7 @@ export default defineComponent({
509519
state.refundMethod = props.paramRefundMethod
510520
prepopulateRefund()
511521
}
522+
state.isInitialLoading = false
512523
})
513524
514525
function prepopulateRefund () {
@@ -727,4 +738,7 @@ export default defineComponent({
727738
.item-chip {
728739
font-size: 16px !important;
729740
}
741+
.v-overlay {
742+
z-index: 10;
743+
}
730744
</style>

0 commit comments

Comments
 (0)