fix: healthcheck (#175)

* fix: backend health check

* fix: healthcheck in compose

Updated healthcheck command to use Node.js for API check.

* Update Dockerfile

* Update healthcheck command for backend service

* Update healthcheck URL for frontend service

* Update Dockerfile

* Add healthcheck parameters to backend and frontend services

* Add curl installation to Dockerfile

* Remove continue-on-error from Docker Compose step

Removed continue-on-error option from Docker Compose step.

Author: mishraomp

.github/workflows/.e2e.yml

@@ -27,7 +27,7 @@ jobs:
           FLYWAY_IMAGE: ghcr.io/${{ github.repository }}/migrations:${{ inputs.tag }}
           FRONTEND_IMAGE: ghcr.io/${{ github.repository }}/frontend:${{ inputs.tag }}
         run: docker compose up -d --wait
-        continue-on-error: true
+        
       - name: Docker Compose Logs
         if:  ( inputs.frontend_url == 'http://localhost:3000' )
         run: docker compose logs
@@ -62,4 +62,4 @@ jobs:
           E2E_BASE_URL: ${{ inputs.frontend_url }}
           CI: 'true'
         run: |
-          npx playwright test --project="chromium" --reporter=blob
+          npx playwright test --project="chromium" --reporter=blob

backend/Dockerfile

@@ -30,9 +30,9 @@ COPY --from=build /app/dist ./dist
 
 # Boilerplate, not used in OpenShift/Kubernetes
 EXPOSE 3001
-HEALTHCHECK --start-period=2s --start-interval=5s --interval=30s --timeout=3s CMD curl -f http://localhost:30001/api
+HEALTHCHECK --start-period=2s --start-interval=5s --interval=30s --timeout=3s CMD ["/nodejs/bin/node", "-pe", "require('http').get('http://[::1]:3001/api/health', function(res){console.log('Health check status:', res.statusCode); process.exit(res.statusCode === 200 ? 0 : 1)}).on('error', function(err){console.error('Health check error:', err.message); process.exit(1);});"]
 
 
 # Nonroot user, limit heap size to 50 MB
 USER nonroot
-CMD ["--max-old-space-size=50", "/app/dist/main"]
+CMD ["--max-old-space-size=150", "/app/dist/main"]

docker-compose.yml

@@ -62,7 +62,12 @@ services:
       context: ./backend
     ports: ["3001:3001"]
     healthcheck:
-      test: ["CMD", "curl", "-f", "http://localhost:3001/api"]
+      start_interval: 5s
+      start_period: 5s
+      interval: 10s
+      timeout: 3s
+      retries: 6
+      test: ["CMD","/nodejs/bin/node", "-pe", "require('http').get('http://[::1]:3001/api/health', function(res){console.log('Health check status:', res.statusCode); process.exit(res.statusCode === 200 ? 0 : 1)}).on('error', function(err){console.error('Health check error:', err.message); process.exit(1);});"]
     working_dir: "/app"
 
   frontend:
@@ -77,7 +82,12 @@ services:
     image: ${FRONTEND_IMAGE:-frontend}
     ports: ["3000:3000"]
     healthcheck:
-      test: ["CMD", "curl", "-f", "http://localhost:3000"]
+      start_interval: 5s
+      start_period: 5s
+      interval: 10s
+      timeout: 3s
+      retries: 6
+      test: ["CMD", "curl", "-f", "http://0.0.0.0:3001/health"]
     working_dir: "/app"
     depends_on:
       backend:

frontend/Dockerfile

@@ -7,8 +7,11 @@ COPY . ./
 RUN npm run deploy
 
 # Deploy using Caddy to host static files
-FROM caddy:2.10.2-alpine
-RUN apk add --no-cache ca-certificates
+FROM caddy:2.10.0-alpine
+RUN apk add --no-cache \
+    ca-certificates \
+    curl
+
 
 # Copy static files, verify Caddyfile formatting
 COPY --from=build /app/dist /srv
@@ -17,7 +20,7 @@ RUN caddy fmt /etc/caddy/Caddyfile
 
 # Boilerplate, not used in OpenShift/Kubernetes
 EXPOSE 3000 3001
-HEALTHCHECK --interval=30s --timeout=3s CMD curl -f http://localhost:3001/health
+HEALTHCHECK --interval=30s --timeout=3s CMD curl -f http://0.0.0.0:3001/health
 
 # Nonroot user
 USER 1001