chore: linter (#144)

Author: mishraomp

infrastructure/api/api-gateway.tf

@@ -1,34 +1,34 @@
 # Import common configurations
 module "common" {
   source = "git::https://github.com/bcgov/quickstart-aws-helpers.git//terraform/modules/common?ref=v0.0.5"
-  
-  target_env    = var.target_env
-  app_env       = var.app_env
-  app_name      = var.app_name
-  repo_name     = var.repo_name
-  common_tags   = var.common_tags
+
+  target_env  = var.target_env
+  app_env     = var.app_env
+  app_name    = var.app_name
+  repo_name   = var.repo_name
+  common_tags = var.common_tags
 }
 
 # Import networking configurations
 module "networking" {
   source = "git::https://github.com/bcgov/quickstart-aws-helpers.git//terraform/modules/networking?ref=v0.0.5"
-  
+
   target_env = var.target_env
 }
 
 # API Gateway with VPC Link using the API Gateway module
 module "api_gateway" {
   source = "git::https://github.com/bcgov/quickstart-aws-helpers.git//terraform/modules/api-gateway?ref=v0.0.5"
-  
+
   api_name           = var.app_name
   protocol_type      = "HTTP"
   subnet_ids         = module.networking.subnets.web.ids
   security_group_ids = [module.networking.security_groups.web.id]
   integration_uri    = aws_alb_listener.internal.arn
-  route_key         = "ANY /{proxy+}"
-  stage_name        = "$default"
-  auto_deploy       = true
-  tags              = module.common.common_tags
+  route_key          = "ANY /{proxy+}"
+  stage_name         = "$default"
+  auto_deploy        = true
+  tags               = module.common.common_tags
 }
 
 # Compatibility data sources for existing resource references

infrastructure/api/autoscaling.tf

@@ -8,7 +8,7 @@ resource "aws_appautoscaling_target" "api_target" {
 
 # Automatically scale capacity up by one
 resource "aws_appautoscaling_policy" "api_up" {
-  name            = "${var.app_name}-scale-up"
+  name               = "${var.app_name}-scale-up"
   service_namespace  = "ecs"
   resource_id        = "service/${aws_ecs_cluster.ecs_cluster.name}/${aws_ecs_service.node_api_service.name}"
   scalable_dimension = "ecs:service:DesiredCount"
@@ -28,7 +28,7 @@ resource "aws_appautoscaling_policy" "api_up" {
 }
 # Automatically scale capacity down by one
 resource "aws_appautoscaling_policy" "api_down" {
-  name            = "${var.app_name}-scale-down"
+  name               = "${var.app_name}-scale-down"
   service_namespace  = "ecs"
   resource_id        = "service/${aws_ecs_cluster.ecs_cluster.name}/${aws_ecs_service.node_api_service.name}"
   scalable_dimension = "ecs:service:DesiredCount"

infrastructure/api/ecs.tf

@@ -1,5 +1,5 @@
 locals {
-  container_name = "${var.app_name}"
+  container_name = var.app_name
 }
 
 # Try to fetch secrets manager secret, but don't fail if it doesn't exist
@@ -29,25 +29,25 @@ locals {
       password = "changeme"
     }
   )
-  
+
   # Provide default database endpoints with try() for safe access
   db_endpoint = try(
     data.aws_rds_cluster.rds_cluster[0].endpoint,
     "localhost"
   )
-  
+
   db_reader_endpoint = try(
     data.aws_rds_cluster.rds_cluster[0].reader_endpoint,
     "localhost"
   )
-  
+
   # Flag to indicate if database resources are available
   db_resources_available = var.db_cluster_name != "" && length(data.aws_rds_cluster.rds_cluster) > 0
 }
 
 
 resource "aws_ecs_cluster" "ecs_cluster" {
-  name = "${var.app_name}"
+  name = var.app_name
   tags = module.common.common_tags
 }
 
@@ -65,7 +65,7 @@ resource "aws_ecs_cluster_capacity_providers" "ecs_cluster_capacity_providers" {
 
 resource "terraform_data" "trigger_flyway" {
   count = var.db_cluster_name != "" ? 1 : 0
-  input = "${timestamp()}"
+  input = timestamp()
 }
 
 resource "aws_ecs_task_definition" "flyway_task" {
@@ -78,7 +78,7 @@ resource "aws_ecs_task_definition" "flyway_task" {
   execution_role_arn       = aws_iam_role.ecs_task_execution_role.arn
   task_role_arn            = aws_iam_role.app_container_role.arn
   container_definitions = jsonencode([
-    { 
+    {
       name      = "${var.app_name}-flyway"
       image     = "${var.flyway_image}"
       essential = true
@@ -108,7 +108,7 @@ resource "aws_ecs_task_definition" "flyway_task" {
           value = "true"
         }
       ]
-      
+
       logConfiguration = {
         logDriver = "awslogs"
         options = {
@@ -120,15 +120,15 @@ resource "aws_ecs_task_definition" "flyway_task" {
       }
       mountPoints = []
       volumesFrom = []
-      
+
     }
   ])
   lifecycle {
     replace_triggered_by = [terraform_data.trigger_flyway[0]]
   }
   provisioner "local-exec" {
     interpreter = ["bash", "-c"]
-    command = <<-EOF
+    command     = <<-EOF
     set -euo pipefail
 
     max_attempts=5
@@ -194,15 +194,15 @@ resource "aws_ecs_task_definition" "flyway_task" {
 }
 
 resource "aws_ecs_task_definition" "node_api_task" {
-  family                   = "${var.app_name}"
+  family                   = var.app_name
   network_mode             = "awsvpc"
   requires_compatibilities = ["FARGATE"]
   cpu                      = var.api_cpu
   memory                   = var.api_memory
   execution_role_arn       = aws_iam_role.ecs_task_execution_role.arn
   task_role_arn            = aws_iam_role.app_container_role.arn
   container_definitions = jsonencode([
-    {      
+    {
       name      = "${local.container_name}"
       image     = "${var.api_image}"
       essential = true
@@ -232,7 +232,7 @@ resource "aws_ecs_task_definition" "node_api_task" {
           value = "${var.db_schema}"
         },
         {
-          name = "POSTGRES_POOL_SIZE"
+          name  = "POSTGRES_POOL_SIZE"
           value = "${var.postgres_pool_size}"
         },
         {
@@ -268,10 +268,10 @@ resource "aws_ecs_task_definition" "node_api_task" {
 
 
 resource "aws_ecs_service" "node_api_service" {
-  name            = "${var.app_name}"
-  cluster         = aws_ecs_cluster.ecs_cluster.id
-  task_definition = aws_ecs_task_definition.node_api_task.arn
-  desired_count   = 1
+  name                              = var.app_name
+  cluster                           = aws_ecs_cluster.ecs_cluster.id
+  task_definition                   = aws_ecs_task_definition.node_api_task.arn
+  desired_count                     = 1
   health_check_grace_period_seconds = 60
 
   capacity_provider_strategy {
@@ -292,10 +292,10 @@ resource "aws_ecs_service" "node_api_service" {
 
   load_balancer {
     target_group_arn = aws_alb_target_group.app.id
-    container_name   = "${local.container_name}"
+    container_name   = local.container_name
     container_port   = var.app_port
   }
   wait_for_steady_state = true
-  depends_on = [aws_iam_role_policy_attachment.ecs_task_execution_role]
-  tags = module.common.common_tags
+  depends_on            = [aws_iam_role_policy_attachment.ecs_task_execution_role]
+  tags                  = module.common.common_tags
 }

infrastructure/api/iam.tf

@@ -21,7 +21,7 @@ data "aws_iam_policy" "appRDS" {
 resource "aws_iam_role" "ecs_task_execution_role" {
   name               = "${var.app_name}_ecs_role"
   assume_role_policy = data.aws_iam_policy_document.ecs_task_execution_role.json
-  tags = module.common.common_tags
+  tags               = module.common.common_tags
 }
 
 # ECS task execution role policy attachment

infrastructure/api/outputs.tf

@@ -18,7 +18,7 @@ output "database_status" {
   value = {
     cluster_name_provided = var.db_cluster_name != ""
     using_fallback_creds  = !local.db_resources_available
-    db_endpoint          = local.db_endpoint
-    warning = !local.db_resources_available ? "Using fallback database credentials. Ensure database cluster exists before deploying." : null
+    db_endpoint           = local.db_endpoint
+    warning               = !local.db_resources_available ? "Using fallback database credentials. Ensure database cluster exists before deploying." : null
   }
 }

infrastructure/api/vars.tf

@@ -21,39 +21,39 @@ variable "db_schema" {
 
 variable "subnet_app_a" {
   description = "Value of the name tag for a subnet in the APP security group"
-  type = string
-  default = "App_Dev_aza_net"
+  type        = string
+  default     = "App_Dev_aza_net"
 }
 
 variable "subnet_app_b" {
   description = "Value of the name tag for a subnet in the APP security group"
-  type = string
-  default = "App_Dev_azb_net"
+  type        = string
+  default     = "App_Dev_azb_net"
 }
 variable "subnet_web_a" {
   description = "Value of the name tag for a subnet in the APP security group"
-  type = string
-  default = "Web_Dev_aza_net"
+  type        = string
+  default     = "Web_Dev_aza_net"
 }
 
 variable "subnet_web_b" {
   description = "Value of the name tag for a subnet in the APP security group"
-  type = string
-  default = "Web_Dev_azb_net"
+  type        = string
+  default     = "Web_Dev_azb_net"
 }
 
 
 # Networking Variables
 variable "subnet_data_a" {
   description = "Value of the name tag for a subnet in the DATA security group"
-  type = string
-  default = "Data_Dev_aza_net"
+  type        = string
+  default     = "Data_Dev_aza_net"
 }
 
 variable "subnet_data_b" {
   description = "Value of the name tag for a subnet in the DATA security group"
-  type = string
-  default = "Data_Dev_azb_net"
+  type        = string
+  default     = "Data_Dev_azb_net"
 }
 
 variable "app_port" {
@@ -62,7 +62,7 @@ variable "app_port" {
   default     = 3000
 }
 variable "app_name" {
-  description  = " The APP name with environment (app_env)"
+  description = " The APP name with environment (app_env)"
   type        = string
 }
 variable "common_tags" {
@@ -82,28 +82,28 @@ variable "health_check_path" {
   description = "The path for the health check"
   type        = string
   default     = "/api/health"
-  
+
 }
 
 variable "api_cpu" {
-  type = number
-  default     = "256"
+  type    = number
+  default = "256"
 }
 variable "api_memory" {
-  type = number
-  default     = "512"
+  type    = number
+  default = "512"
 }
 variable "aws_region" {
-  type = string
+  type    = string
   default = "ca-central-1"
 }
 variable "min_capacity" {
-  type = number
+  type    = number
   default = 1
 }
 variable "max_capacity" {
-  type = number
-  default = 5
+  type        = number
+  default     = 5
   description = <<EOT
     The maximum number of tasks to run, please consider,
     connection pooling and other factors when setting this value, 
@@ -123,9 +123,9 @@ variable "max_capacity" {
 ## ECR Variables
 
 variable "repository_names" {
-  type        = list(string)
-  default = [ "bcgov/quickstart-aws-containers" ]
-  
+  type    = list(string)
+  default = ["bcgov/quickstart-aws-containers"]
+
 }
 variable "image_tag_mutability" {
   description = "Tag mutability setting for the repository. Must be one of: MUTABLE or IMMUTABLE."
@@ -160,7 +160,7 @@ variable "tags" {
   type        = map(string)
   default     = {}
 }
-variable "db_cluster_name"{
+variable "db_cluster_name" {
   description = "Name of the database cluster"
   type        = string
   default     = ""