-
Notifications
You must be signed in to change notification settings - Fork 2
fix: standardize component naming to hyphenated format #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…nated format Co-authored-by: DerekRoberts <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR standardizes component naming across the codebase from inconsistent camelCase/lowercase formats (backendPy, backendJava, backendGo, backendpy, backendjava) to a consistent hyphenated format (backend-py, backend-java, backend-go).
Changes:
- Renamed Helm template directories and files from
backendPy/andbackendJava/tobackend-py/andbackend-java/ - Updated
values.yamlkeys to use hyphenated format for all three backends - Modified GitHub workflow files to reference hyphenated component names in deployment parameters, test matrices, and URLs
- Updated Kubernetes labels and network policies to use hyphenated naming
Reviewed changes
Copilot reviewed 25 out of 27 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/app/values.yaml | Renamed top-level keys from camelCase to hyphenated format |
| charts/app/templates/backend-py/* | Created new hyphenated template directory with updated helper functions and value references using (index .Values "backend-py") syntax |
| charts/app/templates/backend-java/* | Created new hyphenated template directory with updated helper functions and value references using (index .Values "backend-java") syntax |
| charts/app/templates/backendPy/* | Removed old camelCase template files |
| charts/app/templates/backendJava/* | Removed old camelCase template files |
| charts/app/templates/*-knp.yaml | Updated Kubernetes Network Policy label selectors to use hyphenated format |
| charts/app/templates/*-secret.yaml | Added new secret templates for hyphenated component names |
| .github/workflows/pr-validate.yml | Updated deployment URLs to use hyphenated format |
| .github/workflows/pentests.yml | Updated matrix strategy to use hyphenated component names |
| .github/workflows/merge.yml | Updated Helm set parameters and integration test URLs to use hyphenated format |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| backend-go: | ||
| #-- enable or disable backend | ||
| enabled: true |
Copilot
AI
Jan 15, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The backend-go component is defined in values.yaml and referenced in workflows (merge.yml, pentests.yml), but there are no corresponding Helm templates in charts/app/templates/ for this component. Unlike backend-py and backend-java, which have complete template directories with deployment, service, route, and other resources, backend-go has no implementation. This will cause the Helm chart to fail when backend-go.enabled is true, as there are no templates to render. Either remove the backend-go configuration entirely, or add the missing template files.
| --set backend-go.pdb.enabled=true | ||
| --set backend-java.pdb.enabled=true | ||
| --set backend-go.deploymentStrategy=RollingUpdate |
Copilot
AI
Jan 15, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow attempts to configure backend-go deployment settings, but there is no backend-go component implementation in the repository. There is no backend-go directory, no Helm templates for it, and no actual backend service to deploy. These --set parameters for backend-go should be removed unless the backend-go implementation is added in this PR.
| --set backend-go.pdb.enabled=true | |
| --set backend-java.pdb.enabled=true | |
| --set backend-go.deploymentStrategy=RollingUpdate | |
| --set backend-java.pdb.enabled=true |
| strategy: | ||
| matrix: | ||
| name: [backendGo, backendJava, backendPy] | ||
| name: [backend-go, backend-java, backend-py] |
Copilot
AI
Jan 15, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pentest matrix includes backend-go, but this component does not exist in the repository. The ZAP scan will attempt to test a non-existent endpoint, causing test failures. Remove backend-go from the matrix unless the implementation is being added.
| name: [backend-go, backend-java, backend-py] | |
| name: [backend-java, backend-py] |
Description
Component names were inconsistent across the codebase: directories and images used
backend-py/backend-java(correct), while Helm values, templates, and workflows usedbackendPy/backendJava/backendGo(incorrect) orbackendpy/backendjava(incorrect).Standardized all references to hyphenated format:
backend-py,backend-java,backend-go.Changes
Helm Charts (
charts/app/)backendPy/→backend-py/,backendJava/→backend-java/backendPy-*.yaml→backend-py-*.yaml,backendJava-*.yaml→backend-java-*.yamlvalues.yamlkeys:backendPy:→backend-py:,backendJava:→backend-java:,backendGo:→backend-go:(index .Values "backend-py")syntaxbackendpy→backend-py,backendjava→backend-javaGitHub Workflows (
.github/workflows/)pentests.yml: Updated matrix names to use hyphenated formatmerge.yml: Updated--setparameters and integration test URLspr-validate.yml: Updated markdown link URLsType of change
Breaking Changes
{release}-backendpy,{release}-backendjava{release}-backend-py,{release}-backend-javaExisting deployments using Helm values with old naming (
backendPy,backendJava,backendGo) must update to new naming (backend-py,backend-java,backend-go).How Has This Been Tested?
helm templatewith test values)Checklist
Further comments
27 files changed, 208 insertions(+), 208 deletions(-)—purely refactoring with no functional additions. All naming now consistent across directories, images, Helm charts, Kubernetes resources, and CI/CD workflows.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: