Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 18, 2025

Description

Component names were inconsistent across the codebase: directories and images used backend-py/backend-java (correct), while Helm values, templates, and workflows used backendPy/backendJava/backendGo (incorrect) or backendpy/backendjava (incorrect).

Standardized all references to hyphenated format: backend-py, backend-java, backend-go.

Changes

Helm Charts (charts/app/)

  • Renamed template directories: backendPy/backend-py/, backendJava/backend-java/
  • Renamed template files: backendPy-*.yamlbackend-py-*.yaml, backendJava-*.yamlbackend-java-*.yaml
  • Updated values.yaml keys: backendPy:backend-py:, backendJava:backend-java:, backendGo:backend-go:
  • Updated helper template functions and Values references to use (index .Values "backend-py") syntax
  • Updated Kubernetes labels: backendpybackend-py, backendjavabackend-java

GitHub Workflows (.github/workflows/)

  • pentests.yml: Updated matrix names to use hyphenated format
  • merge.yml: Updated --set parameters and integration test URLs
  • pr-validate.yml: Updated markdown link URLs

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Breaking Changes

⚠️ Route hostnames and resource names will change:

  • Before: {release}-backendpy, {release}-backendjava
  • After: {release}-backend-py, {release}-backend-java

Existing deployments using Helm values with old naming (backendPy, backendJava, backendGo) must update to new naming (backend-py, backend-java, backend-go).

How Has This Been Tested?

  • Helm template syntax validation (helm template with test values)
  • Verified route hostnames render with hyphenated format
  • Verified Kubernetes labels use hyphenated format
  • CodeQL security scan passed
  • Code review completed

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

27 files changed, 208 insertions(+), 208 deletions(-)—purely refactoring with no functional additions. All naming now consistent across directories, images, Helm charts, Kubernetes resources, and CI/CD workflows.

Original prompt

This section details on the original issue you should resolve

<issue_title>fix: inconsistent component naming</issue_title>
<issue_description>Our components do not follow consistent naming across templates, deployments, folders, ZAP scans and more. Make them consistent without breaking everything!

Good names:

  • backend-py
  • backend-java

Bad names:

  • backendpy
  • backendPy
  • backendjava
  • backendjava</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Copilot AI changed the title [WIP] Fix inconsistent component naming across templates and folders fix: standardize component naming to hyphenated format Dec 18, 2025
Copilot AI requested a review from DerekRoberts December 18, 2025 20:42
@DerekRoberts DerekRoberts moved this from New to Active in DevOps (NR) Dec 19, 2025
@DerekRoberts DerekRoberts marked this pull request as ready for review January 15, 2026 18:00
Copilot AI review requested due to automatic review settings January 15, 2026 18:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes component naming across the codebase from inconsistent camelCase/lowercase formats (backendPy, backendJava, backendGo, backendpy, backendjava) to a consistent hyphenated format (backend-py, backend-java, backend-go).

Changes:

  • Renamed Helm template directories and files from backendPy/ and backendJava/ to backend-py/ and backend-java/
  • Updated values.yaml keys to use hyphenated format for all three backends
  • Modified GitHub workflow files to reference hyphenated component names in deployment parameters, test matrices, and URLs
  • Updated Kubernetes labels and network policies to use hyphenated naming

Reviewed changes

Copilot reviewed 25 out of 27 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
charts/app/values.yaml Renamed top-level keys from camelCase to hyphenated format
charts/app/templates/backend-py/* Created new hyphenated template directory with updated helper functions and value references using (index .Values "backend-py") syntax
charts/app/templates/backend-java/* Created new hyphenated template directory with updated helper functions and value references using (index .Values "backend-java") syntax
charts/app/templates/backendPy/* Removed old camelCase template files
charts/app/templates/backendJava/* Removed old camelCase template files
charts/app/templates/*-knp.yaml Updated Kubernetes Network Policy label selectors to use hyphenated format
charts/app/templates/*-secret.yaml Added new secret templates for hyphenated component names
.github/workflows/pr-validate.yml Updated deployment URLs to use hyphenated format
.github/workflows/pentests.yml Updated matrix strategy to use hyphenated component names
.github/workflows/merge.yml Updated Helm set parameters and integration test URLs to use hyphenated format

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +53 to 55
backend-go:
#-- enable or disable backend
enabled: true
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The backend-go component is defined in values.yaml and referenced in workflows (merge.yml, pentests.yml), but there are no corresponding Helm templates in charts/app/templates/ for this component. Unlike backend-py and backend-java, which have complete template directories with deployment, service, route, and other resources, backend-go has no implementation. This will cause the Helm chart to fail when backend-go.enabled is true, as there are no templates to render. Either remove the backend-go configuration entirely, or add the missing template files.

Copilot uses AI. Check for mistakes.
Comment on lines +104 to +106
--set backend-go.pdb.enabled=true
--set backend-java.pdb.enabled=true
--set backend-go.deploymentStrategy=RollingUpdate
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow attempts to configure backend-go deployment settings, but there is no backend-go component implementation in the repository. There is no backend-go directory, no Helm templates for it, and no actual backend service to deploy. These --set parameters for backend-go should be removed unless the backend-go implementation is added in this PR.

Suggested change
--set backend-go.pdb.enabled=true
--set backend-java.pdb.enabled=true
--set backend-go.deploymentStrategy=RollingUpdate
--set backend-java.pdb.enabled=true

Copilot uses AI. Check for mistakes.
strategy:
matrix:
name: [backendGo, backendJava, backendPy]
name: [backend-go, backend-java, backend-py]
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pentest matrix includes backend-go, but this component does not exist in the repository. The ZAP scan will attempt to test a non-existent endpoint, causing test failures. Remove backend-go from the matrix unless the implementation is being added.

Suggested change
name: [backend-go, backend-java, backend-py]
name: [backend-java, backend-py]

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Active

Development

Successfully merging this pull request may close these issues.

fix: inconsistent component naming

2 participants