-
Notifications
You must be signed in to change notification settings - Fork 9
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Describe the Bug
The path to tsconfig.json in frontend/.eslintrc.yml is pointing to ./frontend/tsconfig.json, so linting typescript files isn't working.
** Steps To Reproduce**
Steps to reproduce the behaviour:
- Clone repo
cd frontend && npm install- Open
frontend/src/App.tsx - Look at the first import, there will be an error since it can't find
tsconfig.json(tested in neovim and vscode)

To fix:
- Remove
./frontendfromparserOptions/projectin.eslintrc.yml - Once fixed if you open
frontend/e2e/pages/dashboard.tsthere will be an error since eslint is working now, but/e2e/isn't included in.tsconfigso add the e2e directory to theincludein.tsconfig - Since linting was broken there are some basic lint errors in some files such as App.tsx, though just saving the files seems to fix most that I found so either:
cd frontend && npx prettier . --write
cd frontend && npx eslint --fix .
Some other considerations:
- The backend and tests folder don't have a prettier config. Perhaps create new ones or move
.pretterrc.ymlup one directory along with a.prettierignorethat ignores folders like.git, .github, charts, migrationswould be nice. - Backend and tests folder don't have an eslint config, it would be nice if the whole project had a base eslint config to extend and share some rules.
Thanks for your consideration and your hard work on this helpful repo!
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working
Type
Projects
Status
Done
