Skip to content

Commit 2461a2a

Browse files
severinbeauvaisSeverin Beauvais
andauthored
30320 - Fixed incorrect key for navigating to Business Dashboard (#3492)
Co-authored-by: Severin Beauvais <severin.beauvais@gov.bc.ca>
1 parent 50dd588 commit 2461a2a

File tree

11 files changed

+23
-20
lines changed

11 files changed

+23
-20
lines changed

auth-web/.env.example

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,7 @@ VUE_APP_XLP_FORMS_URL="https://www2.gov.bc.ca/assets/gov/employment-business-and
1818

1919
#vaults web-url
2020
VUE_APP_REGISTRY_HOME_URL="https://dev.bcregistry.gov.bc.ca/"
21-
VUE_APP_AUTH_WEB_URL="https://dev.account.bcregistry.gov.bc.ca/"
22-
VUE_APP_DASHBOARD_URL="https://dev.business.bcregistry.gov.bc.ca/"
21+
VUE_APP_BUSINESS_DASH_URL="https://dev.business-dashboard.bcregistry.gov.bc.ca/"
2322
VUE_APP_DOCUMENTS_UI_URL="https://documents-ui-dev.firebaseapp.com"
2423
VUE_APP_ENTITY_SELECTOR_URL="https://entity-selection-dev.apps.silver.devops.gov.bc.ca/"
2524
VUE_APP_SITEMINDER_LOGOUT_URL="https://logontest7.gov.bc.ca/clp-cgi/logoff.cgi"

auth-web/devops/vaults.env

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ VUE_APP_ONE_STOP_URL="op://relationship/$APP_ENV/auth-web/ONE_STOP_URL"
1313

1414
#vaults web-url
1515
VUE_APP_REGISTRY_HOME_URL="op://web-url/$APP_ENV/registry/REGISTRY_HOME_URL"
16-
VUE_APP_AUTH_WEB_URL="op://web-url/$APP_ENV/auth-web/AUTH_WEB_URL"
17-
VUE_APP_DASHBOARD_URL="op://web-url/$APP_ENV/business/DASHBOARD_URL"
16+
17+
VUE_APP_BUSINESS_DASH_URL="op://web-url/$APP_ENV/business-dash/BUSINESS_DASH_URL"
1818
VUE_APP_DOCUMENTS_UI_URL="op://web-url/$APP_ENV/documents-ui/DOCUMENTS_UI_URL"
1919
VUE_APP_ENTITY_SELECTOR_URL="op://web-url/$APP_ENV/entity-selector/ENTITY_SELECTOR_URL"
2020
VUE_APP_SITEMINDER_LOGOUT_URL="op://web-url/$APP_ENV/siteminder/SITEMINDER_LOGOUT_URL"

auth-web/package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

auth-web/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "auth-web",
3-
"version": "2.10.18",
3+
"version": "2.10.19",
44
"appName": "Auth Web",
55
"sbcName": "SBC Common Components",
66
"private": true,

auth-web/src/components/auth/BusinessContactForm.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ export default class BusinessContactForm extends Vue {
172172
if (this.$route.query.redirect) {
173173
this.$router.push({ path: `/account/${this.currentOrganization.id}` })
174174
} else {
175-
const businessUrl = `${ConfigHelper.getBusinessURL()}${this.currentBusiness.businessIdentifier}`
175+
const businessUrl = `${ConfigHelper.getBusinessDashURL()}${this.currentBusiness.businessIdentifier}`
176176
window.location.href = appendAccountId(businessUrl, this.currentOrganization.id.toString())
177177
}
178178
}

auth-web/src/stores/business.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -518,7 +518,7 @@ export const useBusinessStore = defineStore('business', () => {
518518

519519
// redirect to Filings UI
520520
ConfigHelper.addToSession(SessionStorageKeys.BusinessIdentifierKey, tempRegNum)
521-
const redirectURL = `${ConfigHelper.getBusinessURL()}${tempRegNum}`
521+
const redirectURL = `${ConfigHelper.getBusinessDashURL()}${tempRegNum}`
522522
window.location.href = decodeURIComponent(redirectURL)
523523
} catch (error) {
524524
// eslint-disable-next-line no-console

auth-web/src/util/config-helper.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,9 @@ export default class ConfigHelper {
3232
// }
3333
}
3434

35-
static getBusinessURL () {
35+
static getBusinessDashURL () {
3636
// this needs trailing slash
37-
return `${import.meta.env.VUE_APP_DASHBOARD_URL}`
37+
return `${import.meta.env.VUE_APP_BUSINESS_DASH_URL}`
3838
}
3939

4040
static getRegistryHomeURL () {

auth-web/src/util/navigation.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { appendAccountId } from 'sbc-common-components/src/util/common-util'
66
/** Navigation handler for entities dashboard. */
77
export const goToDashboard = (businessIdentifier: string): void => {
88
ConfigHelper.addToSession(SessionStorageKeys.BusinessIdentifierKey, businessIdentifier)
9-
const redirectURL = `${ConfigHelper.getBusinessURL()}${businessIdentifier}`
9+
const redirectURL = `${ConfigHelper.getBusinessDashURL()}${businessIdentifier}`
1010
window.location.href = appendAccountId(decodeURIComponent(redirectURL))
1111
}
1212

auth-web/src/views/auth/BusinessProfileView.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ export default class BusinessProfileView extends Mixins(AccountChangeMixin, Next
107107
this.$router.push('/home')
108108
}
109109
} else {
110-
const businessUrl = `${ConfigHelper.getBusinessURL()}${this.currentBusiness.businessIdentifier}`
110+
const businessUrl = `${ConfigHelper.getBusinessDashURL()}${this.currentBusiness.businessIdentifier}`
111111
window.location.href = appendAccountId(businessUrl, this.currentOrganization.id.toString())
112112
}
113113
}

auth-web/src/views/auth/staff/IncorporationSearchResultView.vue

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -92,25 +92,29 @@ export default class IncorporationSearchResultView extends Vue {
9292
generatePasscodeDialog: GeneratePasscodeView
9393
}
9494
95-
get actions (): object[] {
95+
get actions (): any[] {
9696
if (this.isThereAnAffiliatedAccount) {
9797
return [
98-
{ title: 'Manage Business',
98+
{
99+
title: 'Manage Business',
99100
icon: 'mdi-view-dashboard',
100101
event: this.manageBusinessEvent
101102
},
102-
{ title: 'Manage Account',
103+
{
104+
title: 'Manage Account',
103105
icon: 'mdi-domain',
104106
event: this.manageAccountEvent
105107
}
106108
]
107109
} else {
108110
return [
109-
{ title: 'Manage Business',
111+
{
112+
title: 'Manage Business',
110113
icon: 'mdi-view-dashboard',
111114
event: this.manageBusinessEvent
112115
},
113-
{ title: 'Generate Passcode',
116+
{
117+
title: 'Generate Passcode',
114118
icon: 'mdi-lock-outline',
115119
event: this.generatePasscodeEvent
116120
}
@@ -186,7 +190,7 @@ export default class IncorporationSearchResultView extends Vue {
186190
const businessIdentifier = this.currentBusiness.businessIdentifier
187191
const filingId = this.filingID
188192
189-
let url = `${ConfigHelper.getBusinessURL()}${businessIdentifier}`
193+
let url = `${ConfigHelper.getBusinessDashURL()}${businessIdentifier}`
190194
191195
if (filingId) {
192196
url += `?filing_id=${filingId}`

0 commit comments

Comments
 (0)