30088 Better handle error responses (#3498)

Co-authored-by: Severin Beauvais <severin.beauvais@gov.bc.ca>

Author: severinbeauvais

auth-web/.env.example

@@ -1,22 +1,16 @@
-# Base Path Opensift: /business/auth/ Firebase: /
 VUE_APP_PATH="/"
 
-#vaults Shared
+# vaults canadapost
 VUE_APP_ADDRESS_COMPLETE_KEY=
 
-#vaults auth-web
+# vaults auth-web
 VUE_APP_AFFIDAVIT_FILE_SIZE="73KB"
 VUE_APP_PAYMENT_PAYEE_NAME="BC Registries"
 VUE_APP_FILE_SERVER_URL="https://storage.googleapis.com/auth-static-resources-dev"
 VUE_APP_APPROVE_ACCOUNT_SLA_DAYS="3-5"
 VUE_APP_ONE_STOP_URL="https://dev.onestop.gov.bc.ca/"
-VUE_APP_SOCIETIES_URL="https://www.bcregistry.ca/societies/"
-VUE_APP_CORP_FORMS_URL="https://www2.gov.bc.ca/gov/content/employment-business/business/managing-a-business/permits-licences/businesses-incorporated-companies/forms-corporate-registry"
-VUE_APP_LLP_FORMS_URL="https://www2.gov.bc.ca/assets/gov/employment-business-and-economic-development/business-management/permits-licences-and-registration/registries-packages/pack_01_llp_-_registration_forms_package.pdf"
-VUE_APP_LP_FORMS_URL="https://www2.gov.bc.ca/assets/gov/employment-business-and-economic-development/business-management/permits-licences-and-registration/registries-forms/reg_791_-_declaration_for_bc_limited_partnership.pdf"
-VUE_APP_XLP_FORMS_URL="https://www2.gov.bc.ca/assets/gov/employment-business-and-economic-development/business-management/permits-licences-and-registration/registries-forms/reg_790_-_declaration_for_extraprovincial_limited_partnership.pdf"
 
-#vaults web-url
+# vaults web-url
 VUE_APP_REGISTRY_HOME_URL="https://dev.bcregistry.gov.bc.ca/"
 VUE_APP_BUSINESS_DASH_URL="https://dev.business-dashboard.bcregistry.gov.bc.ca/"
 VUE_APP_DOCUMENTS_UI_URL="https://documents-ui-dev.firebaseapp.com"
@@ -33,15 +27,19 @@ VUE_APP_BUSINESS_CREATE_URL="https://dev.create.business.bcregistry.gov.bc.ca/"
 VUE_APP_CORPORATE_ONLINE_URL="https://www.corporateonline.gov.bc.ca"
 VUE_APP_NRO_URL="https://dev.bcregistrynames.gov.bc.ca/nro/"
 VUE_APP_REGISTRY_SEARCH_URL="https://dev.search.business.bcregistry.gov.bc.ca/"
+VUE_APP_SOCIETIES_URL="https://www.bcregistry.ca/societies/"
+VUE_APP_CORP_FORMS_URL="https://www2.gov.bc.ca/gov/content/employment-business/business/managing-a-business/permits-licences/businesses-incorporated-companies/forms-corporate-registry"
+VUE_APP_LLP_FORMS_URL="https://www2.gov.bc.ca/assets/gov/employment-business-and-economic-development/business-management/permits-licences-and-registration/registries-packages/pack_01_llp_-_registration_forms_package.pdf"
+VUE_APP_LP_FORMS_URL="https://www2.gov.bc.ca/assets/gov/employment-business-and-economic-development/business-management/permits-licences-and-registration/registries-forms/reg_791_-_declaration_for_bc_limited_partnership.pdf"
+VUE_APP_XLP_FORMS_URL="https://www2.gov.bc.ca/assets/gov/employment-business-and-economic-development/business-management/permits-licences-and-registration/registries-forms/reg_790_-_declaration_for_extraprovincial_limited_partnership.pdf"
 VUE_APP_NAMEX_WEB_URL="https://dev.namex.bcregistry.gov.bc.ca/"
 VUE_APP_BUSINESS_REGISTRY_URL="https://dev.business-registry-dashboard.bcregistry.gov.bc.ca/"
 
-#vaults API
+# vaults API
 VUE_APP_AUTH_API_GW_URL="https://test.api.connect.gov.bc.ca/auth-dev"
 VUE_APP_AUTH_API_VERSION="/api/v1"
 VUE_APP_AUTH_API_KEY=
 VUE_APP_LEGAL_API_URL="https://legal-api-dev.apps.silver.devops.gov.bc.ca"
-VUE_APP_LEGAL_API_VERSION="/api/v1"
 VUE_APP_LEGAL_API_VERSION_2="/api/v2"
 VUE_APP_REGISTRIES_SEARCH_API_URL="https://bcregistry-dev.apigee.net/registry-search"
 VUE_APP_REGISTRIES_SEARCH_API_VERSION="/api/v1"
@@ -58,15 +56,15 @@ VUE_APP_MHR_API_URL="https://bcregistry-dev.apigee.net/mhr"
 VUE_APP_MHR_API_VERSION="/api/v1"
 VUE_APP_MHR_API_KEY=""
 
-#vaults launchdarkly
+# vaults launchdarkly
 VUE_APP_AUTH_LD_CLIENT_ID=
 
-#vaults keycloak
+# vaults keycloak
 VUE_APP_KEYCLOAK_AUTH_URL="https://dev.loginproxy.gov.bc.ca/auth"
 VUE_APP_KEYCLOAK_REALM="bcregistry"
 VUE_APP_KEYCLOAK_CLIENTID="connect-web"
 
-#vaults hotjar
+# vaults hotjar
 VUE_APP_HOTJAR_ID=
 
 # Google Analytics

auth-web/devops/vaults.env

@@ -1,19 +1,17 @@
-# Base Path Opensift: /business/auth/ Firebase: /
 VUE_APP_PATH=/
 
-#vaults Shared
+# vaults canadapost
 VUE_APP_ADDRESS_COMPLETE_KEY="op://canadapost/$APP_ENV/address-key/ADDRESS_COMPLETE_KEY"
 
-#vaults auth-web
+# vaults relationship
 VUE_APP_AFFIDAVIT_FILE_SIZE="op://relationship/$APP_ENV/auth-web/AFFIDAVIT_FILE_SIZE"
 VUE_APP_PAYMENT_PAYEE_NAME="op://relationship/$APP_ENV/auth-web/PAYMENT_PAYEE_NAME"
 VUE_APP_FILE_SERVER_URL="op://relationship/$APP_ENV/auth-web/FILE_SERVER_URL"
 VUE_APP_APPROVE_ACCOUNT_SLA_DAYS="op://relationship/$APP_ENV/auth-web/APPROVE_ACCOUNT_SLA_DAYS"
 VUE_APP_ONE_STOP_URL="op://relationship/$APP_ENV/auth-web/ONE_STOP_URL"
 
-#vaults web-url
+# vaults web-url
 VUE_APP_REGISTRY_HOME_URL="op://web-url/$APP_ENV/registry/REGISTRY_HOME_URL"
-
 VUE_APP_BUSINESS_DASH_URL="op://web-url/$APP_ENV/business-dash/BUSINESS_DASH_URL"
 VUE_APP_DOCUMENTS_UI_URL="op://web-url/$APP_ENV/documents-ui/DOCUMENTS_UI_URL"
 VUE_APP_ENTITY_SELECTOR_URL="op://web-url/$APP_ENV/entity-selector/ENTITY_SELECTOR_URL"
@@ -37,12 +35,11 @@ VUE_APP_XLP_FORMS_URL="op://web-url/$APP_ENV/bcregistry/XLP_FORMS_URL"
 VUE_APP_NAMEX_WEB_URL="op://web-url/$APP_ENV/auth-web/NAMEX_WEB_URL"
 VUE_APP_BUSINESS_REGISTRY_URL="op://web-url/$APP_ENV/business-registry-ui/BUSINESS_REGISTRY_URL"
 
-#vaults API
+# vaults API
 VUE_APP_AUTH_API_GW_URL="op://API/$APP_ENV/auth-api/AUTH_API_GW_URL"
 VUE_APP_AUTH_API_KEY="op://API/$APP_ENV/auth-api/AUTH_API_KEY"
 VUE_APP_AUTH_API_VERSION="op://API/$APP_ENV/auth-api/AUTH_API_VERSION"
 VUE_APP_LEGAL_API_URL="op://API/$APP_ENV/legal-api/LEGAL_API_URL"
-VUE_APP_LEGAL_API_VERSION="op://API/$APP_ENV/legal-api/LEGAL_API_VERSION"
 VUE_APP_LEGAL_API_VERSION_2="op://API/$APP_ENV/legal-api/LEGAL_API_VERSION_2"
 VUE_APP_REGISTRIES_SEARCH_API_URL="op://API/$APP_ENV/registries-search-api/REGISTRIES_SEARCH_API_URL"
 VUE_APP_REGISTRIES_SEARCH_API_VERSION="op://API/$APP_ENV/registries-search-api/REGISTRIES_SEARCH_API_VERSION"
@@ -59,16 +56,16 @@ VUE_APP_MHR_API_URL="op://API/$APP_ENV/ppr-api/MHR_API_URL"
 VUE_APP_MHR_API_VERSION="op://API/$APP_ENV/ppr-api/MHR_API_VERSION"
 VUE_APP_MHR_API_KEY="op://API/$APP_ENV/ppr-api/MHR_API_KEY"
 
-#vaults launchdarkly
+# vaults launchdarkly
 VUE_APP_AUTH_LD_CLIENT_ID="op://launchdarkly/$APP_ENV/auth/AUTH_LD_CLIENT_ID"
 
-#vaults keycloak
+# vaults keycloak
 VUE_APP_KEYCLOAK_AUTH_URL="op://keycloak/$APP_ENV/base/KEYCLOAK_AUTH_BASE_URL"
 VUE_APP_KEYCLOAK_REALM="op://keycloak/$APP_ENV/base/KEYCLOAK_REALMNAME"
 VUE_APP_KEYCLOAK_CLIENTID="op://keycloak/$APP_ENV/account-web/UI_KEYCLOAK_RESOURCE_NAME"
 
-#vaults hotjar
+ #vaults hotjar
 VUE_APP_HOTJAR_ID="op://hotjar/$APP_ENV/auth-web/HOTJAR_ID"
 
-# Google Analytics
+# vaults google-analytics
 VUE_APP_GTAG_ID="op://google-analytics/$APP_ENV/developer/GTAG"

auth-web/package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "auth-web",
-  "version": "2.10.20",
+  "version": "2.10.21",
   "appName": "Auth Web",
   "sbcName": "SBC Common Components",
   "private": true,

auth-web/package.json

@@ -273,7 +273,8 @@ export const useBusinessStore = defineStore('business', () => {
   async function loadFiling () {
     const filingID = ConfigHelper.getFromSession(SessionStorageKeys.FilingIdentifierKey)
     state.filingID = filingID
-    const response = await BusinessService.searchFiling(filingID).catch(() => null)
+    const response = await BusinessService.searchFiling(filingID).catch(error => error)
+
     if (response?.status === 200) {
       const businessIdentifier = response?.data.filing.business.identifier
       ConfigHelper.addToSession(SessionStorageKeys.BusinessIdentifierKey, businessIdentifier)
@@ -428,12 +429,13 @@ export const useBusinessStore = defineStore('business', () => {
 
   // Following searchBusiness will search data from legal-api.
   async function searchBusiness (businessIdentifier: string): Promise<LearBusiness> {
-    const response = await BusinessService.searchBusiness(businessIdentifier).catch(() => null)
+    const response = await BusinessService.searchBusiness(businessIdentifier).catch(error => error)
+
     if (response?.status === 200 && response?.data?.business?.legalName) {
       ConfigHelper.addToSession(SessionStorageKeys.BusinessIdentifierKey, businessIdentifier)
       return response.data.business
     } else if (response?.status === 404) {
-      throw Error('No match found for Incorporation Number')
+      throw Error('No match found for Business Number')
     } else {
       throw Error('Search failed')
     }

auth-web/src/stores/business.ts

@@ -111,10 +111,6 @@ export default class ConfigHelper {
     return `${import.meta.env.VUE_APP_AUTH_API_GW_URL}` + '/test/reset'
   }
 
-  static getLegalAPIUrl () {
-    return `${import.meta.env.VUE_APP_LEGAL_API_URL}` + `${import.meta.env.VUE_APP_LEGAL_API_VERSION}`
-  }
-
   static getLegalAPIV2Url () {
     return `${import.meta.env.VUE_APP_LEGAL_API_URL}` + `${import.meta.env.VUE_APP_LEGAL_API_VERSION_2}`
   }

auth-web/src/util/config-helper.ts

@@ -458,19 +458,17 @@ export default defineComponent({
       return identifier.charAt(0).toUpperCase() === 'T'
     }
 
-    const resetSearchState = () => {
-      businessStore.resetCurrentBusiness()
-      businessStore.resetFilingID()
-    }
-
     const updateCurrentBusiness = async () => {
       try {
         // Search for business, action will set session storage
         await businessStore.loadBusiness()
         localVars.affiliatedOrg = await orgStore.getOrganizationForAffiliate()
         localVars.canViewIncorporationSearchResult = true
       } catch (exception) {
-        localVars.errorMessage = exception?.message
+        localVars.errorMessage =
+          exception?.response?.data?.rootCause?.message ||
+          exception?.response?.data?.rootCause ||
+          exception?.message
         localVars.canViewIncorporationSearchResult = false
         businessStore.resetCurrentBusiness()
       }
@@ -489,7 +487,8 @@ export default defineComponent({
     }
 
     const search = async () => {
-      resetSearchState()
+      businessStore.resetCurrentBusiness()
+      businessStore.resetFilingID()
 
       if (isFormValid()) {
         localVars.searchActive = true