Fix default for getFlag. (#334)

seeker25 · web-flow · commit 594804a40292 · 2023-09-27T10:14:09.000-07:00
diff --git a/vue/sbc-common-components/package-lock.json b/vue/sbc-common-components/package-lock.json
diff --git a/vue/sbc-common-components/package.json b/vue/sbc-common-components/package.json
@@ -1,6 +1,6 @@
 {
   "name": "sbc-common-components",
-  "version": "3.0.8",
+  "version": "3.0.9",
   "private": false,
   "description": "Common Vue Components to be used across BC Registries and Online Services.",
   "license": "Apache-2.0",
diff --git a/vue/sbc-common-components/src/services/launchdarkly.services.ts b/vue/sbc-common-components/src/services/launchdarkly.services.ts
@@ -47,9 +47,9 @@ class LaunchDarklyService {
     ConfigHelper.addToSession(SessionStorageKeys.LaunchDarklyFlags, JSON.stringify(this.ldClient.allFlags()))
   }
 
-  public getFlag (flagName: string): any {
+  public getFlag (flagName: string, defaultValue = null): any {
     const ldFlags = JSON.parse(ConfigHelper.getFromSession(SessionStorageKeys.LaunchDarklyFlags) || '{}')
-    return (this.flags && this.flags[flagName]) || (ldFlags && ldFlags[flagName])
+    return (this.flags && this.flags[flagName]) || (ldFlags && ldFlags[flagName]) || defaultValue
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "sbc-common-components",`
`3`		`- "version": "3.0.8",`
	`3`	`+ "version": "3.0.9",`
`4`	`4`	`"private": false,`
`5`	`5`	`"description": "Common Vue Components to be used across BC Registries and Online Services.",`
`6`	`6`	`"license": "Apache-2.0",`
Original file line number	Diff line number	Diff line change
`@@ -47,9 +47,9 @@ class LaunchDarklyService {`
`47`	`47`	`ConfigHelper.addToSession(SessionStorageKeys.LaunchDarklyFlags, JSON.stringify(this.ldClient.allFlags()))`
`48`	`48`	`}`
`49`	`49`
`50`		`- public getFlag (flagName: string): any {`
	`50`	`+ public getFlag (flagName: string, defaultValue = null): any {`
`51`	`51`	`const ldFlags = JSON.parse(ConfigHelper.getFromSession(SessionStorageKeys.LaunchDarklyFlags) \|\| '{}')`
`52`		`- return (this.flags && this.flags[flagName]) \|\| (ldFlags && ldFlags[flagName])`
	`52`	`+ return (this.flags && this.flags[flagName]) \|\| (ldFlags && ldFlags[flagName]) \|\| defaultValue`
`53`	`53`	`}`
`54`	`54`	`}`
`55`	`55`