Skip to content

Commit 13bc411

Browse files
authored
MMI-3346 Fix Notification Service (#2492)
1 parent 5a70147 commit 13bc411

File tree

4 files changed

+23
-16
lines changed

4 files changed

+23
-16
lines changed

db/postgres/README.md

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,15 +74,21 @@ DB_VOLUME=/var/lib/pgsql/data
7474
## Backup Commands
7575

7676
```bash
77+
# RSH into database backup pod
78+
oc -n 9b301c-test rsh db-backup-855b845cc7-zrk7t
79+
80+
# Test connection
81+
psql -h postgres -U admin -d tno
82+
7783
# Backup and zip
78-
pg_dump -h postgres -U admin -C -Fc -v -d tno | gzip > /mnt/data/dev.tar.gz
84+
pg_dump -h postgres -U admin -C -Fc -v -d tno | gzip > /backups/dev.tar.gz
85+
86+
# Copy file to local
87+
oc -n 9b301c-dev rsync db-backup-855b845cc7-zrk7t:/backups/dev.tar.gz /D/db
7988

8089
# Unzip
8190
gzip -dk dev.tar.gz
8291

83-
# Copy file to local
84-
oc -n 9b301c-dev rsync psql-4-zdbv6:/mnt/data/dev.tar.gz /D/db
85-
8692
# Copy file to database server
8793
scp -v /D/db/dev.tar.gz jerfos_a@142.34.249.231:/u02/data/postgres
8894
```

libs/net/ches/ChesService.cs

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -173,12 +173,16 @@ private async Task<string> SendAsync(string endpoint, HttpMethod method)
173173
}
174174
catch (HttpClientRequestException ex)
175175
{
176-
if (ex.Response != null)
176+
if (ex.Response != null && ex.Response.Content.Headers.ContentType?.MediaType?.Contains("json", StringComparison.InvariantCultureIgnoreCase) == true)
177177
{
178-
var response = await this.Client.DeserializeAsync<Ches.Models.ErrorResponseModel>(ex.Response);
179-
var error = String.Join(Environment.NewLine, response?.Errors.Select(e => e.Message) ?? []);
180-
_logger.LogError(ex, "Failed to send/receive request: {code} {url}. Error: {error}", ex.StatusCode, url, error);
181-
throw new ChesException(ex, this.Client, response);
178+
var stream = await ex.Response.Content.ReadAsStreamAsync();
179+
if (stream.CanSeek && stream.Position == stream.Length && stream.Length > 0)
180+
{
181+
var response = await this.Client.DeserializeAsync<Ches.Models.ErrorResponseModel>(ex.Response);
182+
var error = String.Join(Environment.NewLine, response?.Errors.Select(e => e.Message) ?? []);
183+
_logger.LogError(ex, "Failed to send/receive request: {code} {url}. Error: {error}", ex.StatusCode, url, error);
184+
throw new ChesException(ex, this.Client, response);
185+
}
182186
}
183187
_logger.LogError(ex, "Failed to send/receive request: {code} {url}. Error: {error}", ex.StatusCode, url, ex.GetAllMessages());
184188
throw new ChesException("Failed to send message to CHES", ex);

libs/net/core/Http/HttpRequestClient.cs

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -97,11 +97,8 @@ public void Dispose()
9797
throw;
9898
}
9999

100-
// Throw exception because the response failed and cannot be deserialized.
101-
var errorEx = new HttpClientRequestException($"Response must contain JSON but was '{contentType?.MediaType}'.", response.StatusCode);
102-
var responseBytes = responseStream.ReadAllBytes();
103-
errorEx.Data["body"] = Encoding.Default.GetString(responseBytes);
104-
throw errorEx;
100+
// The request response was a failure, wrap exception.
101+
throw new HttpClientRequestException(response);
105102
}
106103

107104
#region HttpResponseMessage Methods

services/net/transcription/appsettings.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,9 @@
5353
"GroupId": "Transcription",
5454
"BootstrapServers": "kafka-broker-0.kafka-headless:9092,kafka-broker-1.kafka-headless:9092,kafka-broker-2.kafka-headless:9092",
5555
"AutoOffsetReset": "Earliest",
56-
"MaxInFlight": 5,
5756
"EnableAutoCommit": false,
58-
"MaxThreads": 10
57+
"MaxThreads": 10,
58+
"MaxPollIntervalMs": 600000
5959
},
6060
"Producer": {
6161
"ClientId": "Transcription",

0 commit comments

Comments
 (0)