Only Ascii characters accepted

[samschott]

It appears that only input not accepted. The basic issue lies in getchar:

bullet/bullet/utils.py

Lines 52 to 55 in 75f620d

	if c in string.printable:
	return c
	else:
	return UNDEFINED_KEY

where string.printable contains only printable ASCII characters. This leaves all people with wider utf-8 input in the cold.

[a-luna]

A response to the stackoverflow post, Test if a python string is printable, provides a clever way to check for non-printable characters:

def is_printable(s):
    return not any(repr(ch).startswith("'\\x") or repr(ch).startswith("'\\u") for ch in s)

Replacing the check in utils.py to use this function would allow any utf-8 printable input to be used:

if is_printable(c):
    return c
else:
    return UNDEFINED_KEY

I'll create a PR with this change, hopefully it will be accepted since allowing utf-8 input should be a requirement (IMO).

[jab]

str.startswith optionally takes a tuple of strings to try. Better to write the above as not any(repr(ch).startswith(("'\\x", "'\\u")) for ch in s)

[a-luna]

I had no idea that you could provide a tuple to startswith, thank you for pointing that out! The updated version will be in the PR.

[danner26]

Hello, my colleague and I use this codebase pretty often in our projects but the original and all forks seem to be stale. We have thus forked into our own project, BulletPrompt.

I have taken the liberty to fix this issue, which will be available in the next release.

PR with fix: danner26#10
Release Version: v2.2.2