fix: correct wrong behavior of the key property named deprecated (#626)#651
Open
BatLeDev wants to merge 1 commit intobcherny:masterfrom
Open
fix: correct wrong behavior of the key property named deprecated (#626)#651BatLeDev wants to merge 1 commit intobcherny:masterfrom
BatLeDev wants to merge 1 commit intobcherny:masterfrom
Conversation
|
@bcherny can this be merged? Changes seem to be valid and it would resolve a bug with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to handle the
deprecatedproperty in JSON schemas more effectively. The main updates include modifications to the validation logic, test snapshots, and end-to-end tests.Handling
deprecatedproperty:src/validator.ts: Added a check to ensure that ifdeprecatedis present inproperties, it returns true, allowing the schema validation to pass.Test updates:
test/__snapshots__/test/test.ts.md: Updated the snapshot to include thedeprecatedproperty in the expected output.test/e2e/deprecated.ts: Added a new test case for thedeprecatedproperty, including a default value and type definition.Spec OpenAPI
According to the OpenAPI 3.1 specification, the
deprecatedproperty is a valid keyword in schemas and operation objects. This update ensures that the validation logic properly recognizesdeprecatedas a legitimate property, preventing unnecessary errors when processing OpenAPI-compliant JSON schemas.Reference: OpenAPI 3.1 Specification - Operation Object
fix #626