Use neostandard + add more static code analysis (#142)

* Use neostandard

* ci: add knip + rimraf + clean up with help of knip

* only run workflows on on `master` branch and PR:s

* tweak new npm scripts

* add installed-check

Author: voxpelli

.github/workflows/test.yml

@@ -1,11 +1,30 @@
 name: tests
 
-on: [pull_request, push]
+on:
+  push:
+    branches:
+      - master
+    tags:
+      - '*'
+  pull_request:
+    branches:
+      - master
 
 env:
   FORCE_COLOR: 2
 
 jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Use Node.js lts/*
+        uses: actions/setup-node@v4
+        with:
+          node-version: lts/*
+      - run: npm i
+      - run: npm run check
+
   test:
     runs-on: ${{ matrix.os }}
 
@@ -22,14 +41,14 @@ jobs:
         with:
           node-version: ${{ matrix.node }}
       - run: npm i
-      - run: npm test
+      - run: npm run test-mocha
       - uses: codecov/codecov-action@v4
         if: ${{ github.event_name == 'pull_request' }}
         with:
           flags: ${{ matrix.os }}-${{ matrix.node }}
 
   automerge:
-    needs: test
+    needs: [lint, test]
     runs-on: ubuntu-latest
     permissions:
       pull-requests: write

.knip.jsonc

@@ -0,0 +1,5 @@
+{
+  "$schema": "https://unpkg.com/knip@5/schema.json",
+  "entry": ["lib/index.js", "bin/*/*.js", "test-workspace/tasks/*.js"],
+  "ignoreDependencies": ["rimraf", "yarn"]
+}

README.md

@@ -7,6 +7,7 @@
 [![Downloads/month](https://img.shields.io/npm/dm/npm-run-all2.svg)](http://www.npmtrends.com/npm-run-all2)
 [![tests](https://github.com/bcomnes/npm-run-all2/workflows/tests/badge.svg)](https://github.com/bcomnes/npm-run-all2/actions)
 [![Coverage Status](https://codecov.io/gh/bcomnes/npm-run-all2/branch/master/graph/badge.svg)](https://codecov.io/gh/bcomnes/npm-run-all2)
+[![neostandard javascript style](https://img.shields.io/badge/code_style-neostandard-brightgreen?style=flat)](https://github.com/neostandard/neostandard)
 
 A CLI tool to run multiple npm-scripts in parallel or sequential.
 

bin/common/bootstrap.js

@@ -8,7 +8,6 @@
 // ------------------------------------------------------------------------------
 // Public Interface
 // ------------------------------------------------------------------------------
-/* eslint-disable no-process-exit */
 
 module.exports = function bootstrap (name) {
   const argv = process.argv.slice(2)
@@ -47,5 +46,3 @@ module.exports = function bootstrap (name) {
       )
   }
 }
-
-/* eslint-enable */

bin/common/parse-cli-args.js

@@ -5,8 +5,6 @@
  */
 'use strict'
 
-/* eslint-disable no-process-env */
-
 // ------------------------------------------------------------------------------
 // Helpers
 // ------------------------------------------------------------------------------
@@ -243,5 +241,3 @@ function parseCLIArgsCore (set, args) {
 module.exports = function parseCLIArgs (args, initialValues, options) {
   return parseCLIArgsCore(new ArgumentSet(initialValues, options), args)
 }
-
-/* eslint-enable */

bin/npm-run-all/main.js

@@ -52,7 +52,7 @@ module.exports = function npmRunAll (args, stdout, stderr) {
             arguments: argv.rest,
             race: group.parallel && argv.race,
             npmPath: argv.npmPath,
-            aggregateOutput: group.parallel && argv.aggregateOutput
+            aggregateOutput: group.parallel && argv.aggregateOutput,
           }
         ))
       },
@@ -61,14 +61,12 @@ module.exports = function npmRunAll (args, stdout, stderr) {
 
     if (!argv.silent) {
       promise.catch(err => {
-        // eslint-disable-next-line no-console
         console.error('ERROR:', err.message)
       })
     }
 
     return promise
   } catch (err) {
-    // eslint-disable-next-line no-console
     console.error('ERROR:', err.message)
 
     return Promise.reject(err)

bin/run-p/main.js

@@ -52,20 +52,18 @@ module.exports = function npmRunAll (args, stdout, stderr) {
         arguments: argv.rest,
         race: argv.race,
         npmPath: argv.npmPath,
-        aggregateOutput: argv.aggregateOutput
+        aggregateOutput: argv.aggregateOutput,
       }
     )
 
     if (!argv.silent) {
       promise.catch(err => {
-        // eslint-disable-next-line no-console
         console.error('ERROR:', err.message)
       })
     }
 
     return promise
   } catch (err) {
-    // eslint-disable-next-line no-console
     console.error('ERROR:', err.message)
 
     return Promise.reject(err)

bin/run-s/main.js

@@ -49,20 +49,18 @@ module.exports = function npmRunAll (args, stdout, stderr) {
         packageConfig: argv.packageConfig,
         silent: argv.silent,
         arguments: argv.rest,
-        npmPath: argv.npmPath
+        npmPath: argv.npmPath,
       }
     )
 
     if (!argv.silent) {
       promise.catch(err => {
-        // eslint-disable-next-line no-console
         console.error('ERROR:', err.message)
       })
     }
 
     return promise
   } catch (err) {
-    // eslint-disable-next-line no-console
     console.error('ERROR:', err.message)
 
     return Promise.reject(err)

eslint.config.js

@@ -0,0 +1,9 @@
+'use strict'
+
+module.exports = [
+  ...require('neostandard')({
+    env: ['mocha'],
+    ignores: require('neostandard').resolveIgnoresFromGitignore(),
+    ts: true,
+  }),
+]

lib/index.js

@@ -228,7 +228,7 @@ function maxLength (length, name) {
  * @returns {Promise}
  *   A promise object which becomes fullfilled when all npm-scripts are completed.
  */
-module.exports = function npmRunAll (patternOrPatterns, options) { // eslint-disable-line complexity
+module.exports = function npmRunAll (patternOrPatterns, options) {
   const stdin = (options && options.stdin) || null
   const stdout = (options && options.stdout) || null
   const stderr = (options && options.stderr) || null
@@ -290,14 +290,14 @@ module.exports = function npmRunAll (patternOrPatterns, options) { // eslint-dis
             enabled: printLabel,
             width: labelWidth,
             lastPrefix: null,
-            lastIsLinebreak: true
+            lastIsLinebreak: true,
           },
           printName,
           packageInfo: x.packageInfo,
           race,
           maxParallel,
           npmPath,
-          aggregateOutput
+          aggregateOutput,
         })
       })
   } catch (err) {