VID-1097: Correct hidden completion on percent

Daniel Thies · Daniel Thies · commit 420e5fdfd610 · 2025-11-20T15:12:56.000-06:00
diff --git a/classes/completion/custom_completion.php b/classes/completion/custom_completion.php
@@ -70,7 +70,7 @@ public function get_state(string $rule): int {
 
                 $status = $status && (
                     empty($rules['completion_on_percent']) ||
-                    (($sessions->get_percent() * 100) >= $rules['completion_on_percent_value'])
+                    (($sessions->get_percent() * 100) >= $rules['completion_on_percent'])
                 );
                 break;
             default:
diff --git a/lib.php b/lib.php
@@ -726,7 +726,7 @@ function videotime_get_coursemodule_info($coursemodule) {
                     = $instance->completion_on_view_time_second;
             }
             if ($instance->completion_on_percent) {
-                $result->customdata['hiddencompletionrules']['completion_on_percent_value']
+                $result->customdata['hiddencompletionrules']['completion_on_percent']
                     = $instance->completion_on_percent_value;
             }
             $result->customdata['hiddencompletionrules']['completion_on_finish'] = $instance->completion_on_finish;

Original file line number	Diff line number	Diff line change
`@@ -726,7 +726,7 @@ function videotime_get_coursemodule_info($coursemodule) {`
`726`	`726`	`= $instance->completion_on_view_time_second;`
`727`	`727`	`}`
`728`	`728`	`if ($instance->completion_on_percent) {`
`729`		`- $result->customdata['hiddencompletionrules']['completion_on_percent_value']`
	`729`	`+ $result->customdata['hiddencompletionrules']['completion_on_percent']`
`730`	`730`	`= $instance->completion_on_percent_value;`
`731`	`731`	`}`
`732`	`732`	`$result->customdata['hiddencompletionrules']['completion_on_finish'] = $instance->completion_on_finish;`