fix: Properly disable date and time pickers when onChanged is null (Fixes #1210)

Author: bdlukaa

CHANGELOG.md

@@ -5,6 +5,7 @@
 - fix: Custom `ContextMenuButtonItem` are correctly displayed on text selection control ([#1212](https://github.com/bdlukaa/fluent_ui/pull/1212))
 - fix: `TreeView`'s focus always starts at first or last item ([#834](https://github.com/bdlukaa/fluent_ui/issues/834), [#1195](https://github.com/bdlukaa/fluent_ui/pull/1195))
 - fix: `InfoBar` no longer throw error when automatically closing ([#955](https://github.com/bdlukaa/fluent_ui/issues/955), [#1215](https://github.com/bdlukaa/fluent_ui/pull/1215))
+- fix: Properly disable date and time pickers when `onChanged` is null ([#1210](https://github.com/bdlukaa/fluent_ui/issues/1210))
 
 ## 4.11.3
 

lib/src/controls/form/number_box.dart

@@ -701,7 +701,7 @@ class NumberBoxState<T extends num> extends State<NumberBox<T>> {
       value = num.tryParse(controller.text);
       if (value == null && widget.allowExpressions) {
         try {
-          value = Parser()
+          value = ShuntingYardParser()
               .parse(controller.text)
               .evaluate(EvaluationType.REAL, ContextModel());
           // If the value is infinite or not a number, we reset the value with

lib/src/controls/pickers/date_picker.dart

@@ -83,10 +83,10 @@ class DatePicker extends StatefulWidget {
 
   /// Whenever the current selected date is changed by the user.
   ///
-  /// If null, the picker is considered disabled
+  /// If `null`, the picker is considered disabled
   final ValueChanged<DateTime>? onChanged;
 
-  /// Whenever the user cancels the date change.
+  /// Called when the user cancels the picker.
   final VoidCallback? onCancel;
 
   /// The content of the header
@@ -330,16 +330,15 @@ class DatePickerState extends State<DatePicker> {
       child: (context, open) => HoverButton(
         autofocus: widget.autofocus,
         focusNode: widget.focusNode,
-        onPressed: () async {
-          _monthController.dispose();
-          // _monthController = null;
-          _dayController.dispose();
-          // _dayController = null;
-          _yearController.dispose();
-          // _yearController = null;
-          initControllers();
-          await open();
-        },
+        onPressed: widget.onChanged == null
+            ? null
+            : () async {
+                _monthController.dispose();
+                _dayController.dispose();
+                _yearController.dispose();
+                initControllers();
+                await open();
+              },
         builder: (context, states) {
           if (states.isDisabled) states = <WidgetState>{};
           const divider = Divider(

lib/src/controls/pickers/time_picker.dart

@@ -242,13 +242,15 @@ class TimePickerState extends State<TimePicker>
       child: (context, open) => HoverButton(
         focusNode: widget.focusNode,
         autofocus: widget.autofocus,
-        onPressed: () async {
-          _hourController.dispose();
-          _minuteController.dispose();
-          _amPmController.dispose();
-          initControllers();
-          await open();
-        },
+        onPressed: widget.onChanged == null
+            ? null
+            : () async {
+                _hourController.dispose();
+                _minuteController.dispose();
+                _amPmController.dispose();
+                initControllers();
+                await open();
+              },
         builder: (context, states) {
           const divider = Divider(
             direction: Axis.vertical,