Merge pull request #143 from beNative/codex/analyze-automatic-update-system-issues-xdvup5

Stop uploading duplicate app-update manifests

Author: beNative

scripts/__tests__/release-workflow.test.mjs

@@ -432,6 +432,14 @@ test('release workflow verifies metadata directories across platforms and publis
   });
 
   const manifestEntries = new Set(readManifestEntries(await fs.readFile(manifestPath, 'utf8')));
+  const appUpdateRelative = path.relative(
+    repoPath(),
+    path.join(ia32.releaseDir, 'win-ia32-unpacked', 'resources', 'app-update.yml'),
+  );
+  assert(
+    !manifestEntries.has(appUpdateRelative),
+    'app-update.yml should not be uploaded to the release',
+  );
   const expectedMetadataUploads = [x64.metadataPath, linux.metadataPath, mac.metadataPath];
   for (const metadataPath of expectedMetadataUploads) {
     assert(metadataPath, 'metadataPath should be defined for uploaded manifests');

scripts/generate-release-notes.mjs

@@ -136,6 +136,17 @@ function isAutoUpdateSupportFile(filename) {
   return true;
 }
 
+function shouldUploadMetadataFile(filename) {
+  const lower = filename.toLowerCase();
+  if (lower.endsWith('.blockmap')) {
+    return true;
+  }
+  if (lower.startsWith('latest') && lower.endsWith('.yml')) {
+    return true;
+  }
+  return false;
+}
+
 function normaliseInstallerFileName(fileName) {
   if (!fileName.toLowerCase().endsWith('.exe')) {
     return fileName;
@@ -256,7 +267,7 @@ async function collectAssets(artifactRoot) {
           filePath,
           artifactDir,
           assetName: path.basename(filePath),
-          upload: true,
+          upload: shouldUploadMetadataFile(fileName),
         });
         continue;
       }