Skip to content

Commit 2a4494e

Browse files
authored
bump Makie compat (#112)
* bump Makie compat * makesize -> markersize * try deleting `markerstrokewidth`
1 parent 2feb223 commit 2a4494e

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

.github/workflows/CI.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ jobs:
2929
- x64
3030
makie:
3131
- '0.20'
32+
- '0.21'
3233
steps:
3334
- uses: actions/checkout@v4
3435
- uses: julia-actions/setup-julia@v1

Project.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name = "Lighthouse"
22
uuid = "ac2c24cd-07f0-4848-96b2-1b82c3ea0e59"
33
authors = ["Beacon Biosignals, Inc."]
4-
version = "0.17.0"
4+
version = "0.17.1"
55

66
[deps]
77
ArrowTypes = "31f734f8-188a-4ce0-8406-c8a06bd891cd"
@@ -30,7 +30,7 @@ ArrowTypes = "1, 2"
3030
CairoMakie = "0.11"
3131
DataFrames = "1.3"
3232
Legolas = "0.5"
33-
Makie = "0.20"
33+
Makie = "0.20, 0.21"
3434
StatsBase = "0.33, 0.34"
3535
Tables = "1.7"
3636
TensorBoardLogger = "0.1"

ext/LighthouseMakieExt.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ function Lighthouse.plot_binary_discrimination_calibration_curves!(subfig::GridP
161161
# but we want kw > BinaryDiscriminationCalibrationCurves > Scatter, so we need to somehow set things
162162
# after the theme merging above, especially, since we also pass those to series!,
163163
# which then again tries to merge the kw args with the theme.
164-
set_from_kw!(scatter_theme, :makersize, kw, 5)
164+
set_from_kw!(scatter_theme, :markersize, kw, 5)
165165
set_from_kw!(scatter_theme, :marker, kw, :rect)
166166

167167
if ismissing(per_expert_calibration_curves)
@@ -179,7 +179,7 @@ function Lighthouse.plot_binary_discrimination_calibration_curves!(subfig::GridP
179179

180180
calibration = get_theme(subfig, :BinaryDiscriminationCalibrationCurves,
181181
:CalibrationCurve;
182-
solid_color=:navyblue, markerstrokewidth=0)
182+
solid_color=:navyblue)
183183

184184
set_from_kw!(calibration, :markersize, kw, 5)
185185
set_from_kw!(calibration, :marker, kw, :rect)

0 commit comments

Comments
 (0)