Skip to content

Commit 0354df9

Browse files
danvetgregkh
authored andcommitted
drm/rcar: Nuke preclose hook
commit 0a34662 upstream. Again since the drm core takes care of event unlinking/disarming this is now just needless code. Cc: Laurent Pinchart <[email protected]> Acked-by: Daniel Stone <[email protected]> Reviewed-by: Alex Deucher <[email protected]> Reviewed-by: Laurent Pinchart <[email protected]> Signed-off-by: Daniel Vetter <[email protected]> Link: http://patchwork.freedesktop.org/patch/msgid/[email protected] Signed-off-by: Nhan Nguyen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent b5a4867 commit 0354df9

File tree

3 files changed

+0
-32
lines changed

3 files changed

+0
-32
lines changed

drivers/gpu/drm/rcar-du/rcar_du_crtc.c

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -282,26 +282,6 @@ static void rcar_du_crtc_update_planes(struct rcar_du_crtc *rcrtc)
282282
* Page Flip
283283
*/
284284

285-
void rcar_du_crtc_cancel_page_flip(struct rcar_du_crtc *rcrtc,
286-
struct drm_file *file)
287-
{
288-
struct drm_pending_vblank_event *event;
289-
struct drm_device *dev = rcrtc->crtc.dev;
290-
unsigned long flags;
291-
292-
/* Destroy the pending vertical blanking event associated with the
293-
* pending page flip, if any, and disable vertical blanking interrupts.
294-
*/
295-
spin_lock_irqsave(&dev->event_lock, flags);
296-
event = rcrtc->event;
297-
if (event && event->base.file_priv == file) {
298-
rcrtc->event = NULL;
299-
event->base.destroy(&event->base);
300-
drm_crtc_vblank_put(&rcrtc->crtc);
301-
}
302-
spin_unlock_irqrestore(&dev->event_lock, flags);
303-
}
304-
305285
static void rcar_du_crtc_finish_page_flip(struct rcar_du_crtc *rcrtc)
306286
{
307287
struct drm_pending_vblank_event *event;

drivers/gpu/drm/rcar-du/rcar_du_crtc.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,6 @@ enum rcar_du_output {
6767

6868
int rcar_du_crtc_create(struct rcar_du_group *rgrp, unsigned int index);
6969
void rcar_du_crtc_enable_vblank(struct rcar_du_crtc *rcrtc, bool enable);
70-
void rcar_du_crtc_cancel_page_flip(struct rcar_du_crtc *rcrtc,
71-
struct drm_file *file);
7270
void rcar_du_crtc_suspend(struct rcar_du_crtc *rcrtc);
7371
void rcar_du_crtc_resume(struct rcar_du_crtc *rcrtc);
7472

drivers/gpu/drm/rcar-du/rcar_du_drv.c

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -220,15 +220,6 @@ static int rcar_du_load(struct drm_device *dev, unsigned long flags)
220220
return ret;
221221
}
222222

223-
static void rcar_du_preclose(struct drm_device *dev, struct drm_file *file)
224-
{
225-
struct rcar_du_device *rcdu = dev->dev_private;
226-
unsigned int i;
227-
228-
for (i = 0; i < rcdu->num_crtcs; ++i)
229-
rcar_du_crtc_cancel_page_flip(&rcdu->crtcs[i], file);
230-
}
231-
232223
static void rcar_du_lastclose(struct drm_device *dev)
233224
{
234225
struct rcar_du_device *rcdu = dev->dev_private;
@@ -271,7 +262,6 @@ static struct drm_driver rcar_du_driver = {
271262
| DRIVER_ATOMIC,
272263
.load = rcar_du_load,
273264
.unload = rcar_du_unload,
274-
.preclose = rcar_du_preclose,
275265
.lastclose = rcar_du_lastclose,
276266
.set_busid = drm_platform_set_busid,
277267
.get_vblank_counter = drm_vblank_no_hw_counter,

0 commit comments

Comments
 (0)