Skip to content

Commit 2ebfde9

Browse files
stashlukjRobertCNelson
authored andcommitted
of: overlay: remove sysfs_create_groups call
This crashes the kernel when an runtime overlay is applied.
1 parent e19643b commit 2ebfde9

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

drivers/of/overlay.c

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -828,13 +828,6 @@ static int __of_overlay_create(struct device_node *tree,
828828
if (err)
829829
goto err_revert_overlay;
830830

831-
err = sysfs_create_groups(&ov->kobj, ov->attr_groups);
832-
if (err != 0) {
833-
pr_err("%s: sysfs_create_groups() failed for tree@%s\n",
834-
__func__, tree->full_name);
835-
goto err_remove_kobj;
836-
}
837-
838831
ov->kobj.kset = ov_kset;
839832
err = kobject_add(&ov->kobj, NULL, "%d", id);
840833
if (err != 0) {
@@ -852,8 +845,6 @@ static int __of_overlay_create(struct device_node *tree,
852845

853846
return id;
854847

855-
err_remove_kobj:
856-
kobject_put(&ov->kobj);
857848
err_cancel_overlay:
858849
of_changeset_revert(&ov->cset);
859850
err_revert_overlay:

0 commit comments

Comments
 (0)