make assert more generic

Author: beakerandjake

src/actions/assertPuzzleHasLevel.js

@@ -1,21 +1,16 @@
 import { logger } from '../logger.js';
-import { getConfigValue } from '../config.js';
+import { getAllPuzzlesForYear } from '../validation/validatePuzzle.js';
 
 /**
  * Asserts that the days puzzle has the level.
  * All days have two levels except for the last day which has one.
  */
-export const assertPuzzleHasLevel = ({ day, level } = {}) => {
-  // no need to validate if not the last day.
-  if (day !== getConfigValue('aoc.validation.days').at(-1)) {
-    return true;
+export const assertPuzzleHasLevel = ({ year, day, level } = {}) => {
+  const hasLevel = getAllPuzzlesForYear(year).some(
+    (x) => x.level === level && x.day === day
+  );
+  if (!hasLevel) {
+    logger.error(`Day ${day} does not have level ${level}.`);
   }
-
-  // only level one is valid on the last day.
-  if (level !== 1) {
-    logger.error('Day 25 only has one level.');
-    return false;
-  }
-
-  return true;
+  return hasLevel;
 };

tests/actions/assertPuzzleHasLevel.test.js

@@ -3,9 +3,12 @@ import { mockConfig, mockLogger } from '../mocks.js';
 
 // setup mocks
 mockLogger();
-const { getConfigValue } = mockConfig();
+jest.unstable_mockModule('src/validation/validatePuzzle.js', () => ({
+  getAllPuzzlesForYear: jest.fn(),
+}));
 
 // import after mocks set up
+const { getAllPuzzlesForYear } = await import('../../src/validation/validatePuzzle.js');
 const { assertPuzzleHasLevel } = await import(
   '../../src/actions/assertPuzzleHasLevel.js'
 );
@@ -15,26 +18,28 @@ describe('assertPuzzleHasLevel()', () => {
     jest.resetAllMocks();
   });
 
-  test('returns true if not last day', () => {
-    const days = [1, 2, 3, 4, 5];
-    getConfigValue.mockReturnValue(days);
-    for (let i = 0; i < days.length - 1; i++) {
-      const result = assertPuzzleHasLevel({ year: 2022, day: days[i], level: 1 });
+  test('returns true if puzzle has level', () => {
+    const puzzles = [
+      { year: 2022, day: 1, level: 1 },
+      { year: 2022, day: 1, level: 2 },
+      { year: 2022, day: 1, level: 3 },
+      { year: 2022, day: 2, level: 1 },
+    ];
+    getAllPuzzlesForYear.mockReturnValue(puzzles);
+    for (const puzzle of puzzles) {
+      const result = assertPuzzleHasLevel(puzzle);
       expect(result).toBe(true);
     }
   });
 
-  test('returns false if last day and level is two', () => {
-    const days = [1, 2, 3, 4, 5];
-    getConfigValue.mockReturnValue(days);
-    const result = assertPuzzleHasLevel({ year: 2022, day: days.at(-1), level: 2 });
+  test('returns false if puzzle does not have level', () => {
+    getAllPuzzlesForYear.mockReturnValue([
+      { year: 2022, day: 1, level: 1 },
+      { year: 2022, day: 1, level: 2 },
+      { year: 2022, day: 1, level: 3 },
+      { year: 2022, day: 2, level: 1 },
+    ]);
+    const result = assertPuzzleHasLevel({ year: 2022, day: 1, level: 4 });
     expect(result).toBe(false);
   });
-
-  test('returns true if last day and level is one', () => {
-    const days = [1, 2, 3, 4, 5];
-    getConfigValue.mockReturnValue(days);
-    const result = assertPuzzleHasLevel({ year: 2022, day: days.at(-1), level: 1 });
-    expect(result).toBe(true);
-  });
 });