add tests for updating profile

Author: jeremylow

testdata/update_profile.json

@@ -0,0 +1 @@
+{"follow_request_sent": null, "profile_image_url_https": "https://pbs.twimg.com/profile_images/968861535127949312/v7ZnBn4I_normal.jpg", "location": "philly", "created_at": "Sun Sep 11 23:49:28 +0000 2011", "profile_banner_url": "https://pbs.twimg.com/profile_banners/372018022/1475799101", "has_extended_profile": false, "is_translation_enabled": false, "profile_background_image_url": "http://abs.twimg.com/images/themes/theme1/bg.png", "description": "these people have addresses | #botally", "statuses_count": 4083, "profile_sidebar_fill_color": "000000", "following": null, "profile_location": null, "lang": "en", "default_profile_image": false, "verified": false, "notifications": null, "profile_image_url": "http://pbs.twimg.com/profile_images/968861535127949312/v7ZnBn4I_normal.jpg", "geo_enabled": false, "favourites_count": 20700, "profile_link_color": "EE3355", "utc_offset": -18000, "protected": true, "profile_sidebar_border_color": "000000", "friends_count": 497, "screen_name": "__jcbl__", "profile_background_color": "FFFFFF", "url": "https://t.co/wtg3XyA3vL", "id": 372018022, "entities": {"description": {"urls": []}, "url": {"urls": [{"display_url": "iseverythingstilltheworst.com", "expanded_url": "http://iseverythingstilltheworst.com", "url": "https://t.co/wtg3XyA3vL", "indices": [0, 23]}]}}, "followers_count": 189, "profile_background_image_url_https": "https://abs.twimg.com/images/themes/theme1/bg.png", "profile_use_background_image": false, "contributors_enabled": false, "translator_type": "none", "default_profile": false, "profile_background_tile": false, "name": "jeremy", "id_str": "372018022", "listed_count": 6, "profile_text_color": "000000", "is_translator": false, "time_zone": "Eastern Time (US & Canada)"}

tests/test_api_30.py

@@ -1753,3 +1753,18 @@ def test_outgoing_friendships(self):
         assert resp
         assert isinstance(resp, list)
         assert resp[0] == 12
+
+    @responses.activate
+    def test_update_profile(self):
+        with open('testdata/update_profile.json') as f:
+            responses.add(POST, DEFAULT_URL, f.read())
+        resp = self.api.UpdateProfile(
+            name='jeremy',
+            location='philly',
+            profileURL='example.com',
+            description='test',
+            profile_link_color='#e35',
+            include_entities=True,
+            skip_status=True)
+        assert resp
+        assert isinstance(resp, twitter.User)

twitter/api.py

@@ -4373,49 +4373,37 @@ def UpdateProfile(self,
         """Update's the authenticated user's profile data.
 
         Args:
-          name:
+          name (str, optional):
             Full name associated with the profile.
-            Maximum of 20 characters. [Optional]
-          profileURL:
+          profileURL (str, optional):
             URL associated with the profile.
             Will be prepended with "http://" if not present.
-            Maximum of 100 characters. [Optional]
-          location:
+          location (str, optional):
             The city or country describing where the user of the account is located.
             The contents are not normalized or geocoded in any way.
-            Maximum of 30 characters. [Optional]
-          description:
+          description (str, optional):
             A description of the user owning the account.
-            Maximum of 160 characters. [Optional]
-          profile_link_color:
+          profile_link_color (str, optional):
             hex value of profile color theme. formated without '#' or '0x'. Ex:  FF00FF
-            [Optional]
-          include_entities:
+          include_entities (bool, optional):
             The entities node will be omitted when set to False.
-            [Optional]
-          skip_status:
+          skip_status (bool, optional):
             When set to either True, t or 1 then statuses will not be included
-            in the returned user objects. [Optional]
+            in the returned user objects.
 
         Returns:
           A twitter.User instance representing the modified user.
         """
         url = '%s/account/update_profile.json' % (self.base_url)
-        data = {}
-        if name:
-            data['name'] = name
-        if profileURL:
-            data['url'] = profileURL
-        if location:
-            data['location'] = location
-        if description:
-            data['description'] = description
-        if profile_link_color:
-            data['profile_link_color'] = profile_link_color
-        if include_entities:
-            data['include_entities'] = include_entities
-        if skip_status:
-            data['skip_status'] = skip_status
+        data = {
+            'name': name,
+            'url': profileURL,
+            'location': location,
+            'description': description,
+            'profile_link_color': profile_link_color,
+            'include_entities': include_entities,
+            'skip_status': skip_status,
+        }
 
         resp = self._RequestUrl(url, 'POST', data=data)
         data = self._ParseAndCheckTwitter(resp.content.decode('utf-8'))