Combination of binary and ternary subdivisions

[manumeter]

For our fork of the player, I've added subdivisions 12 and 24 to allow combinations of (regular) binary rhythms with triplets. Therefore, I've also added some CSS and a function that detects triplets and adds a CSS class to allow correct spacing and highlighting.
Additionally, I've changed the CSS a little bit to allow consistent spacing even for shoutings with long text.

Here are some screenshots:

I'm happy to contribute this to the upstream codebase if there is interest. If not, feel free to close this issue.

Thanks again for your amazing work!

[cdauth]

I think I don’t completely understand yet what you have done there. In the app there is already a subdivision of 12 that is called “4⁄4 with triplets” in the UI. Can’t your song already be achieved with that?

[manumeter]

Ah you're right, I didn't notice that you also have the 12 subdivisions. The 2nd example screenshot however requires the 24 subdivisions (because of the doubles + triplets).

But my change is more regarding the visual representation. The two core differences to upstream:

• Table width is fixed, no matter what number of strokes and stroke labels occur (with visible overlaps where needed, e.g. screenshot 3, and no displacements in areas with many strokes).
• For subdivisons 12 and 24, whenever triplets occur, the table changes it's layout to three instead of four cells (and the strokes are coloured blue) to help people recognize the pattern correctly.

[manumeter]

Here a quick example of with/without my changes:

Before (table widths differ slightly, triplets in table with four cells):

After (table widths are the same (and narrower), triplets are blue and in table with three cells):

I hope this makes more clear what I changed.

[estellecomment]

This is useful for our band too ! If ror-player is not interested, @manumeter could you please share a PR of this work so I can pull it into our fork ? (Though I would much prefer to avoid having to cherry-pick PRs like this, it would be much better if we could merge it into ror-player itself :) )

Why this is a must-have for us : some of our breaks are not currently possible in ror-player : we have to do 6 strokes per bar (writeable with "4/4 with triplets") and then 8 strokes per bar (writeable with "8/8"). So we'd need both "4/4 with triplets" and "8/8" within the same break. We can't do that currently.
Something like this :

The visual representation change (color change + shifting the vertical bars) is nice-to-have (it's not a blocker if we don't have it), but it's very helpful, I'd love to get it too, great work !

[manumeter]

Hi Estelle,

I've attached the patch for what I did here (instead of opening a 2nd PR, as that would require me to fork the upstream repo again, which I'd like to avoid). Please note that this is only the visual part (triplets becoming blue and with 3 instead of 4 table columns).

The thing you need to do to allow what you indicated in your screenshot (which is also possible with the upstream ror-player code, just not in this visual representation) is to add the time 24 in src/config.ts to config.times and increase playTime to the least common multiple of all the times you have in your config (and add the required i18n value(s)).

pattern-player-subdivisions.patch

[estellecomment]

Thanks for the tip, it works! ❤️

It is going to be a bit painful to write and read though, so I think your patch will be very useful :)

I have time to push a PR with your patch if you like. I'll do my best to make you the author of the change, since you did the work. I can give you access to my fork so that you can open the PR yourself, for example.

[manumeter]

I noticed that (with or without my patch) the upbeat table is not very nice formatted with some subdivisions. I'll try to fix this soon, then, a PR would be reasonable from my perspective.

[manumeter]

So, I've fixed the upbeat issue and created the PR for this (found out that it's possible to have multiple PRs through branches 🙃).