Rename ReflectionAttribute::getAsObject to ReflectionAttribute::newInstance

Author: beberlei

Zend/tests/attributes/002_rfcexample.phpt

@@ -28,7 +28,7 @@ namespace {
 
     var_dump($attributes[0]->getName());
     var_dump($attributes[0]->getArguments());
-    var_dump($attributes[0]->getAsObject());
+    var_dump($attributes[0]->newInstance());
 }
 --EXPECTF--
 string(28) "My\Attributes\SingleArgument"

Zend/tests/attributes/005_objects.phpt

@@ -18,8 +18,8 @@ class A1
 $ref = new \ReflectionFunction(<<A1('test')>> function () { });
 
 foreach ($ref->getAttributes() as $attr) {
-	$obj = $attr->getAsObject();
-	
+	$obj = $attr->newInstance();
+
 	var_dump(get_class($obj), $obj->name, $obj->ttl);
 }
 
@@ -28,7 +28,7 @@ echo "\n";
 $ref = new \ReflectionFunction(<<A1>> function () { });
 
 try {
-	$ref->getAttributes()[0]->getAsObject();
+	$ref->getAttributes()[0]->newInstance();
 } catch (\ArgumentCountError $e) {
 	var_dump('ERROR 1', $e->getMessage());
 }
@@ -38,7 +38,7 @@ echo "\n";
 $ref = new \ReflectionFunction(<<A1([])>> function () { });
 
 try {
-	$ref->getAttributes()[0]->getAsObject();
+	$ref->getAttributes()[0]->newInstance();
 } catch (\TypeError $e) {
 	var_dump('ERROR 2', $e->getMessage());
 }
@@ -48,7 +48,7 @@ echo "\n";
 $ref = new \ReflectionFunction(<<A2>> function () { });
 
 try {
-	$ref->getAttributes()[0]->getAsObject();
+	$ref->getAttributes()[0]->newInstance();
 } catch (\Error $e) {
 	var_dump('ERROR 3', $e->getMessage());
 }
@@ -63,7 +63,7 @@ class A3
 $ref = new \ReflectionFunction(<<A3>> function () { });
 
 try {
-	$ref->getAttributes()[0]->getAsObject();
+	$ref->getAttributes()[0]->newInstance();
 } catch (\Error $e) {
 	var_dump('ERROR 4', $e->getMessage());
 }
@@ -75,7 +75,7 @@ class A4 { }
 $ref = new \ReflectionFunction(<<A4(1)>> function () { });
 
 try {
-	$ref->getAttributes()[0]->getAsObject();
+	$ref->getAttributes()[0]->newInstance();
 } catch (\Error $e) {
 	var_dump('ERROR 5', $e->getMessage());
 }

Zend/tests/attributes/007_wrong_compiler_attributes.phpt

@@ -9,6 +9,6 @@ class Foo
 }
 
 $ref = new ReflectionClass(Foo::class);
-var_dump($ref->getAttributes()[0]->getAsObject());
+var_dump($ref->getAttributes()[0]->newInstance());
 --EXPECTF--
 Fatal error: The PhpCompilerAttribute can only be used by internal classes, use PhpAttribute instead in %s

ext/reflection/php_reflection.c

@@ -6647,9 +6647,9 @@ static void attribute_ctor_cleanup(zval *obj, zval *args, uint32_t argc) /* {{{
 }
 /* }}} */
 
-/* {{{ proto public string ReflectionAttribute::getAsObject()
+/* {{{ proto public string ReflectionAttribute::newInstance()
  *	   Returns the attribute as an object */
-ZEND_METHOD(ReflectionAttribute, getAsObject)
+ZEND_METHOD(ReflectionAttribute, newInstance)
 {
 	reflection_object *intern;
 	attribute_reference *attr;

ext/reflection/php_reflection.stub.php

@@ -541,7 +541,7 @@ public function getDefaultValueConstantName() {}
 
     /** @return bool */
     public function isVariadic() {}
-    
+
     /** @return ReflectionAttribute[] */
     public function getAttributes(?string $name = null, int $flags = 0) {}
 }
@@ -656,7 +656,7 @@ final class ReflectionAttribute
 {
     public function getName(): string {}
     public function getArguments(): array {}
-    public function getAsObject(): object {}
+    public function newInstance(): object {}
 
     private function __clone() {}
 

ext/reflection/php_reflection_arginfo.h

@@ -472,7 +472,7 @@ ZEND_END_ARG_INFO()
 
 #define arginfo_class_ReflectionAttribute_getArguments arginfo_class_ReflectionUnionType_getTypes
 
-ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_class_ReflectionAttribute_getAsObject, 0, 0, IS_OBJECT, 0)
+ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_class_ReflectionAttribute_newInstance, 0, 0, IS_OBJECT, 0)
 ZEND_END_ARG_INFO()
 
 #define arginfo_class_ReflectionAttribute___clone arginfo_class_ReflectionFunctionAbstract___clone
@@ -673,7 +673,7 @@ ZEND_METHOD(ReflectionReference, getId);
 ZEND_METHOD(ReflectionReference, __construct);
 ZEND_METHOD(ReflectionAttribute, getName);
 ZEND_METHOD(ReflectionAttribute, getArguments);
-ZEND_METHOD(ReflectionAttribute, getAsObject);
+ZEND_METHOD(ReflectionAttribute, newInstance);
 ZEND_METHOD(ReflectionAttribute, __clone);
 ZEND_METHOD(ReflectionAttribute, __construct);
 
@@ -971,7 +971,7 @@ static const zend_function_entry class_ReflectionReference_methods[] = {
 static const zend_function_entry class_ReflectionAttribute_methods[] = {
 	ZEND_ME(ReflectionAttribute, getName, arginfo_class_ReflectionAttribute_getName, ZEND_ACC_PUBLIC)
 	ZEND_ME(ReflectionAttribute, getArguments, arginfo_class_ReflectionAttribute_getArguments, ZEND_ACC_PUBLIC)
-	ZEND_ME(ReflectionAttribute, getAsObject, arginfo_class_ReflectionAttribute_getAsObject, ZEND_ACC_PUBLIC)
+	ZEND_ME(ReflectionAttribute, newInstance, arginfo_class_ReflectionAttribute_newInstance, ZEND_ACC_PUBLIC)
 	ZEND_ME(ReflectionAttribute, __clone, arginfo_class_ReflectionAttribute___clone, ZEND_ACC_PRIVATE)
 	ZEND_ME(ReflectionAttribute, __construct, arginfo_class_ReflectionAttribute___construct, ZEND_ACC_PRIVATE)
 	ZEND_FE_END