Skip to content

Consolidate Shutdown methods #1069

@cappel89

Description

@cappel89

In a recent PR (#1066), the shutdown logic for the GUIServer (bec_widgets/cli/server.py) was adapted. However, this class is only started if the gui starts through the BECIPythonClient.

Otherwise, relevant processes like the RPCServer are started through the BECDispatcher (https://github.com/bec-project/bec_widgets/blob/pre_release_v3/bec_widgets/utils/bec_dispatcher.py#L241). This is for example the case if we start the main application (bec_widgets/appplications/main_app.py).

If we start the main_app, we are now missing some of the cleanup that is implemented in the shutdown method of the GUIServer, like rpc_server.shutdown(). This should be carefully reviewed and consolidated.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions