feat: data health and reconciliation polish

- Fix concurrent DbContext operations in DataHealthService.AnalyzeAsync (sequential execution)
- dotnet format cleanup across controllers, services, and test files
- Navigation links between existing and new reconciliation pages
- XML documentation for new public API surface
- Feature 125 status updated to Done

Refs: #125
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: Copilot

docs/125-data-health-and-statement-reconciliation.md

@@ -1,5 +1,5 @@
 # Feature 125: Data Health & Statement Reconciliation
-> **Status:** Planning  
+> **Status:** Done  
 > **Priority:** High  
 > **Effort:** Large (2 sub-features, ~12 vertical slices)
 

src/BudgetExperiment.Application/DataHealth/DataHealthService.cs

@@ -48,19 +48,18 @@ public DataHealthService(
     /// <inheritdoc />
     public async Task<DataHealthReportDto> AnalyzeAsync(Guid? accountId, CancellationToken ct)
     {
-        var duplicatesTask = FindDuplicatesAsync(accountId, ct);
-        var outliersTask = FindOutliersAsync(accountId, ct);
-        var dateGapsTask = FindDateGapsAsync(accountId, minGapDays: 14, ct);
-        var uncategorizedTask = GetUncategorizedSummaryAsync(ct);
-
-        await Task.WhenAll(duplicatesTask, outliersTask, dateGapsTask, uncategorizedTask);
+        // Sequential: DbContext is scoped per request and cannot handle concurrent operations.
+        var duplicates = await FindDuplicatesAsync(accountId, ct);
+        var outliers = await FindOutliersAsync(accountId, ct);
+        var dateGaps = await FindDateGapsAsync(accountId, minGapDays: 14, ct);
+        var uncategorized = await GetUncategorizedSummaryAsync(ct);
 
         return new DataHealthReportDto
         {
-            Duplicates = await duplicatesTask,
-            Outliers = await outliersTask,
-            DateGaps = await dateGapsTask,
-            Uncategorized = await uncategorizedTask,
+            Duplicates = duplicates,
+            Outliers = outliers,
+            DateGaps = dateGaps,
+            Uncategorized = uncategorized,
         };
     }
 

src/BudgetExperiment.Client/Models/CurrencyList.cs

@@ -12,7 +12,12 @@ public static class CurrencyList
     /// <summary>
     /// Gets the list of common currencies.
     /// </summary>
-    public static IReadOnlyList<CurrencyOption> Currencies { get; } = new CurrencyOption[]
+    public static IReadOnlyList<CurrencyOption> Currencies
+    {
+        get;
+    }
+
+    = new CurrencyOption[]
     {
         new("USD", "US Dollar", "$"),
         new("EUR", "Euro", "\u20ac"),

src/BudgetExperiment.Client/Models/ReportGridDefinition.cs

@@ -31,7 +31,12 @@ public sealed class ReportGridDefinition
     /// <summary>
     /// Gets or sets the breakpoint definitions.
     /// </summary>
-    public Dictionary<string, ReportGridBreakpointDefinition> Breakpoints { get; set; } =
+    public Dictionary<string, ReportGridBreakpointDefinition> Breakpoints
+    {
+        get; set;
+    }
+
+    =
         new(StringComparer.OrdinalIgnoreCase)
         {
             ["lg"] = new ReportGridBreakpointDefinition { Columns = DefaultColumnsLg },

src/BudgetExperiment.Client/Models/ReportWidgetDefinition.cs

@@ -12,7 +12,10 @@ public sealed class ReportWidgetDefinition
     /// <summary>
     /// Gets or sets the widget identifier.
     /// </summary>
-    public Guid Id { get; set; }
+    public Guid Id
+    {
+        get; set;
+    }
 
     /// <summary>
     /// Gets or sets the widget type.
@@ -27,16 +30,27 @@ public sealed class ReportWidgetDefinition
     /// <summary>
     /// Gets or sets the grid layouts per breakpoint.
     /// </summary>
-    public Dictionary<string, ReportWidgetLayoutPosition> Layouts { get; set; } =
+    public Dictionary<string, ReportWidgetLayoutPosition> Layouts
+    {
+        get; set;
+    }
+
+    =
         new(StringComparer.OrdinalIgnoreCase);
 
     /// <summary>
     /// Gets or sets sizing constraints for the widget.
     /// </summary>
-    public ReportWidgetConstraints? Constraints { get; set; }
+    public ReportWidgetConstraints? Constraints
+    {
+        get; set;
+    }
 
     /// <summary>
     /// Gets or sets the widget configuration.
     /// </summary>
-    public ReportWidgetConfigDefinition? Config { get; set; }
+    public ReportWidgetConfigDefinition? Config
+    {
+        get; set;
+    }
 }

src/BudgetExperiment.Client/Pages/DataHealth/DataHealthViewModel.cs

@@ -25,16 +25,28 @@ public DataHealthViewModel(IBudgetApiService api)
     }
 
     /// <summary>Gets or sets the callback to notify the Razor page that state has changed.</summary>
-    public Action? OnStateChanged { get; set; }
+    public Action? OnStateChanged
+    {
+        get; set;
+    }
 
     /// <summary>Gets a value indicating whether data is currently loading.</summary>
-    public bool IsLoading { get; private set; }
+    public bool IsLoading
+    {
+        get; private set;
+    }
 
     /// <summary>Gets the current error message, if any.</summary>
-    public string? ErrorMessage { get; private set; }
+    public string? ErrorMessage
+    {
+        get; private set;
+    }
 
     /// <summary>Gets the full data health report.</summary>
-    public DataHealthReportDto? Report { get; private set; }
+    public DataHealthReportDto? Report
+    {
+        get; private set;
+    }
 
     /// <summary>Gets the count of duplicate clusters.</summary>
     public int DuplicateCount => Report?.Duplicates.Count ?? 0;

src/BudgetExperiment.Client/Pages/Reconciliation.razor

@@ -12,6 +12,11 @@
 <PageTitle>Reconciliation - Budget Experiment</PageTitle>
 
 <div class="page-container">
+    <div class="alert alert-info mb-3" role="alert">
+        <Icon Name="info" Size="16" /> Looking for bank statement reconciliation?
+        <a href="/statement-reconciliation" class="alert-link">Go to Statement Reconciliation</a>
+    </div>
+
     <PageHeader Title="Reconciliation">
         <Actions>
             <button class="btn btn-secondary" @onclick="ToggleSettings" disabled="@isLoading">

src/BudgetExperiment.Client/Pages/StatementReconciliation/ReconciliationDetailViewModel.cs

@@ -25,19 +25,31 @@ public ReconciliationDetailViewModel(IBudgetApiService api)
     }
 
     /// <summary>Gets or sets the callback to notify the Razor page that state has changed.</summary>
-    public Action? OnStateChanged { get; set; }
+    public Action? OnStateChanged
+    {
+        get; set;
+    }
 
     /// <summary>Gets a value indicating whether data is loading.</summary>
     public bool IsLoading { get; private set; } = true;
 
     /// <summary>Gets the current error message, if any.</summary>
-    public string? ErrorMessage { get; private set; }
+    public string? ErrorMessage
+    {
+        get; private set;
+    }
 
     /// <summary>Gets the reconciliation record identifier.</summary>
-    public Guid RecordId { get; private set; }
+    public Guid RecordId
+    {
+        get; private set;
+    }
 
     /// <summary>Gets the reconciliation history records (all, so we can find the specific one).</summary>
-    public ReconciliationRecordDto? Record { get; private set; }
+    public ReconciliationRecordDto? Record
+    {
+        get; private set;
+    }
 
     /// <summary>Gets the transactions locked to this reconciliation record.</summary>
     public IReadOnlyList<TransactionDto> Transactions { get; private set; } = [];

src/BudgetExperiment.Client/Pages/StatementReconciliation/ReconciliationHistoryViewModel.cs

@@ -25,19 +25,28 @@ public ReconciliationHistoryViewModel(IBudgetApiService api)
     }
 
     /// <summary>Gets or sets the callback to notify the Razor page that state has changed.</summary>
-    public Action? OnStateChanged { get; set; }
+    public Action? OnStateChanged
+    {
+        get; set;
+    }
 
     /// <summary>Gets a value indicating whether data is loading.</summary>
     public bool IsLoading { get; private set; } = true;
 
     /// <summary>Gets the current error message, if any.</summary>
-    public string? ErrorMessage { get; private set; }
+    public string? ErrorMessage
+    {
+        get; private set;
+    }
 
     /// <summary>Gets the available accounts.</summary>
     public IReadOnlyList<AccountDto> Accounts { get; private set; } = [];
 
     /// <summary>Gets or sets the selected account identifier.</summary>
-    public Guid? SelectedAccountId { get; set; }
+    public Guid? SelectedAccountId
+    {
+        get; set;
+    }
 
     /// <summary>Gets the current page of reconciliation records.</summary>
     public IReadOnlyList<ReconciliationRecordDto> Records { get; private set; } = [];

src/BudgetExperiment.Client/Pages/StatementReconciliation/StatementReconciliationViewModel.cs

@@ -25,31 +25,49 @@ public StatementReconciliationViewModel(IBudgetApiService api)
     }
 
     /// <summary>Gets or sets the callback to notify the Razor page that state has changed.</summary>
-    public Action? OnStateChanged { get; set; }
+    public Action? OnStateChanged
+    {
+        get; set;
+    }
 
     /// <summary>Gets a value indicating whether initial data is loading.</summary>
     public bool IsLoading { get; private set; } = true;
 
     /// <summary>Gets a value indicating whether an action is in progress.</summary>
-    public bool IsProcessing { get; private set; }
+    public bool IsProcessing
+    {
+        get; private set;
+    }
 
     /// <summary>Gets the current error message, if any.</summary>
-    public string? ErrorMessage { get; private set; }
+    public string? ErrorMessage
+    {
+        get; private set;
+    }
 
     /// <summary>Gets the list of accounts available for selection.</summary>
     public IReadOnlyList<AccountDto> Accounts { get; private set; } = [];
 
     /// <summary>Gets or sets the selected account identifier.</summary>
-    public Guid? SelectedAccountId { get; set; }
+    public Guid? SelectedAccountId
+    {
+        get; set;
+    }
 
     /// <summary>Gets or sets the statement closing date.</summary>
     public DateOnly StatementDate { get; set; } = DateOnly.FromDateTime(DateTime.UtcNow);
 
     /// <summary>Gets or sets the balance from the bank statement.</summary>
-    public decimal? StatementBalance { get; set; }
+    public decimal? StatementBalance
+    {
+        get; set;
+    }
 
     /// <summary>Gets the computed cleared balance (InitialBalance + sum of cleared transactions).</summary>
-    public decimal ClearedBalance { get; private set; }
+    public decimal ClearedBalance
+    {
+        get; private set;
+    }
 
     /// <summary>Gets the computed difference between statement balance and cleared balance.</summary>
     public decimal Difference => (StatementBalance ?? 0m) - ClearedBalance;
@@ -61,10 +79,16 @@ public StatementReconciliationViewModel(IBudgetApiService api)
     public IReadOnlyList<TransactionDto> Transactions { get; private set; } = [];
 
     /// <summary>Gets the active statement balance DTO, if one exists.</summary>
-    public StatementBalanceDto? ActiveStatementBalance { get; private set; }
+    public StatementBalanceDto? ActiveStatementBalance
+    {
+        get; private set;
+    }
 
     /// <summary>Gets or sets the last completed reconciliation record, if recently completed.</summary>
-    public ReconciliationRecordDto? LastCompletedRecord { get; set; }
+    public ReconciliationRecordDto? LastCompletedRecord
+    {
+        get; set;
+    }
 
     /// <summary>Loads accounts and resets state.</summary>
     /// <param name="ct">Cancellation token.</param>