Skip to content

Commit a56b9cf

Browse files
ehabkostmdroth
authored andcommitted
hw/machine: Free old values of string properties
Reviewed-by: Markus Armbruster <[email protected]> Reviewed-by: Marcel Apfelbaum <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]> Acked-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]> Reviewed-by: Amos Kong <[email protected]> Cc: [email protected] (cherry picked from commit 556068e) Signed-off-by: Michael Roth <[email protected]>
1 parent 0717855 commit a56b9cf

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

hw/core/machine.c

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ static void machine_set_accel(Object *obj, const char *value, Error **errp)
2424
{
2525
MachineState *ms = MACHINE(obj);
2626

27+
g_free(ms->accel);
2728
ms->accel = g_strdup(value);
2829
}
2930

@@ -79,6 +80,7 @@ static void machine_set_kernel(Object *obj, const char *value, Error **errp)
7980
{
8081
MachineState *ms = MACHINE(obj);
8182

83+
g_free(ms->kernel_filename);
8284
ms->kernel_filename = g_strdup(value);
8385
}
8486

@@ -93,6 +95,7 @@ static void machine_set_initrd(Object *obj, const char *value, Error **errp)
9395
{
9496
MachineState *ms = MACHINE(obj);
9597

98+
g_free(ms->initrd_filename);
9699
ms->initrd_filename = g_strdup(value);
97100
}
98101

@@ -107,6 +110,7 @@ static void machine_set_append(Object *obj, const char *value, Error **errp)
107110
{
108111
MachineState *ms = MACHINE(obj);
109112

113+
g_free(ms->kernel_cmdline);
110114
ms->kernel_cmdline = g_strdup(value);
111115
}
112116

@@ -121,6 +125,7 @@ static void machine_set_dtb(Object *obj, const char *value, Error **errp)
121125
{
122126
MachineState *ms = MACHINE(obj);
123127

128+
g_free(ms->dtb);
124129
ms->dtb = g_strdup(value);
125130
}
126131

@@ -135,6 +140,7 @@ static void machine_set_dumpdtb(Object *obj, const char *value, Error **errp)
135140
{
136141
MachineState *ms = MACHINE(obj);
137142

143+
g_free(ms->dumpdtb);
138144
ms->dumpdtb = g_strdup(value);
139145
}
140146

@@ -176,6 +182,7 @@ static void machine_set_dt_compatible(Object *obj, const char *value, Error **er
176182
{
177183
MachineState *ms = MACHINE(obj);
178184

185+
g_free(ms->dt_compatible);
179186
ms->dt_compatible = g_strdup(value);
180187
}
181188

@@ -232,6 +239,7 @@ static void machine_set_firmware(Object *obj, const char *value, Error **errp)
232239
{
233240
MachineState *ms = MACHINE(obj);
234241

242+
g_free(ms->firmware);
235243
ms->firmware = g_strdup(value);
236244
}
237245

0 commit comments

Comments
 (0)