fix: remove deprecated ingress mode handling from NginxController (#2510)

Author: hysyeah

framework/bfl/internal/ingress/controllers/controllers.go

@@ -299,111 +299,6 @@ func (r *NginxController) generateNginxServers() ([]config.Server, error) {
 
 	ctx := context.TODO()
 
-	// get the bfl service
-	var svc corev1.Service
-	err := r.Get(ctx, types.NamespacedName{Namespace: constants.Namespace, Name: constants.BFLServiceName}, &svc)
-	if err != nil {
-		return nil, fmt.Errorf("no bfl service found, %v", err)
-	}
-
-	latestAppPort := func(portName string) int {
-		// compute the latest and available app port
-		var latestPort, maxAppPort int32
-
-		if len(svc.Spec.Ports) < 1 {
-			return int(constants.AppListenFromPort)
-		} else {
-			maxPort := svc.Spec.Ports[0].Port
-			for _, p := range svc.Spec.Ports {
-				if p.Name == portName {
-					// never used
-					// latestPort = p.Port
-					break
-				}
-				if p.Port > maxPort {
-					maxPort = p.Port
-				}
-				if strings.HasPrefix(p.Name, constants.AppPortNamePrefix) && p.Port > maxAppPort {
-					maxAppPort = p.Port
-				}
-			}
-			if maxAppPort+1 > constants.AppListenFromPort && maxAppPort+1 < maxPort {
-				latestPort = maxAppPort + 1
-			} else if maxAppPort < constants.AppListenFromPort {
-				latestPort = constants.AppListenFromPort
-			} else {
-				latestPort = maxPort + 1
-			}
-		}
-		klog.InfoS("Figure out the latest port", "maxAppPort", maxAppPort, "latestPort", latestPort)
-
-		portExists := false
-
-		for _, app := range svc.Spec.Ports {
-			if portName == app.Name {
-				app.Port = latestPort
-				app.TargetPort = intstr.FromInt(int(latestPort))
-				portExists = true
-				break
-			}
-		}
-		if !portExists {
-			// update svc
-			svcPort := corev1.ServicePort{
-				Name:       portName,
-				Protocol:   "TCP",
-				Port:       latestPort,
-				TargetPort: intstr.FromInt(int(latestPort)),
-			}
-			svc.Spec.Ports = append(svc.Spec.Ports, svcPort)
-		}
-		return int(latestPort)
-	}
-
-	// For each applications port server
-	for _, app := range r.apps {
-		if len(app.Spec.Entrances) == 0 {
-			klog.Warningf("invalid app %q, ignore it. app=%s", app.Spec.Name, utils.PrettyJSON(app.Spec))
-			continue
-		}
-
-		for _, entrance := range app.Spec.Entrances {
-			if entrance.Host == "" {
-				continue
-			}
-			appPortName := fmt.Sprintf("%s%s", constants.AppPortNamePrefix, entrance.Name)
-			appPort := latestAppPort(appPortName)
-
-			s := config.Server{
-				Port: appPort,
-				Locations: []config.Location{
-					{
-						Prefix:    "/",
-						ProxyPass: fmt.Sprintf("http://%s.%s.svc.cluster.local:%d", entrance.Host, app.Spec.Namespace, entrance.Port),
-					},
-				},
-			}
-
-			// server patches
-			if patches, ok := patches[entrance.Name]; ok {
-				for _, patch := range patches {
-					_, err = patch(ctx, r, &s)
-					if err != nil {
-						klog.Errorf("failed to apply patch for app %s, %v", app.Spec.Name, err)
-						return nil, err
-					}
-				}
-			}
-
-			servers = append(servers, s)
-		}
-	}
-	klog.Infof("Prepared and updating service ports:\n%v", utils.PrettyJSON(svc.Spec.Ports))
-	err = r.Update(context.TODO(), &svc)
-	if err != nil {
-		return nil, err
-	}
-
 	// For each domain servers
 
 	if r.sslConfigData != nil {