added deadman switch feature #735
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Tests are sad, please rebase from master as a fix was added. Thank you! <3 |
Author
|
Yeah the issue is ping in Rust is kinda trash atm... there's no library that works on all platforms. The one I used worked on Arch but nothing else apparently and the one that works on Windows doesn't work on Arch... I'm gonna hold off on this until there's a stable package |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to my recent escapades of melting a DC firewall and having no way to stop the test once it started, I've added a deadman switch feature.
The idea behind the feature is if you are testing from a remote device that you can only access via the network it will test to make sure the network still works.
If the network goes down and you can no longer ping the default or specified IP addresses, it'll stop the scan so you can recover the network without a trip onsite.
I've added as much testing as I can however to test a ping failure I couldn't find a reliable way to test.
I was thinking of having it test three addresses (10.254.254.254,172.31.254.254, 192.168.254.254) however there is still a possibility that you will have these addresses in a network so it won't be a reliable test.
If you have any testing you would like me to add please let me know.
Also please let me know if you are okay with the names I used.
I hope you will accept the feature addition, I cannot wait for feedback.
Kind regards,
Ella.