Run RuboCop in CI

Author: joshuay03

.github/workflows/lint.yml

@@ -0,0 +1,36 @@
+name: "RuboCop"
+
+on:
+  pull_request:
+    branches: [master]
+
+jobs:
+  rubocop:
+    name: "RuboCop Analysis"
+    runs-on: ubuntu-latest
+    steps:
+      - name: "Checkout the repository"
+        uses: actions/checkout@v4
+        with:
+          ref: ${{ github.event.pull_request.head.sha }}
+          fetch-depth: 2
+
+      - name: "Update and Install Dependencies"
+        run: |
+          sudo apt update
+          sudo apt install libcurl4 libcurl4-openssl-dev
+
+      - name: "Setting up Ruby"
+        uses: ruby/setup-ruby@v1
+        with:
+          bundler-cache: true
+
+      - name: "Configure Bundle testing and install gems"
+        run: |
+          bundle config unset --local without
+          bundle config set --local with 'development'
+          bundle install
+
+      - name: "Run RuboCop"
+        run: |
+          bundle exec rubocop --display-only-safe-correctable

.github/workflows/github_actions.yml .github/workflows/test.yml.github/workflows/github_actions.yml renamed to .github/workflows/test.yml

@@ -1,55 +1,57 @@
-name: 'BrowserStack Test'
+name: "BrowserStack Test"
 
 on:
   pull_request_target:
-    branches: [ master ]
-      
-jobs:    
+    branches: [master]
+
+jobs:
   ubuntu-job:
-    name: 'BrowserStack Test on Ubuntu'
-    runs-on: ubuntu-latest  # Can be self-hosted runner also
+    name: "BrowserStack Test on Ubuntu"
+    runs-on: ubuntu-latest # Can be self-hosted runner also
     environment:
       name: Integrate Pull Request
-    env: 
+    env:
       GITACTIONS: true
     steps:
-
-      - name: 'BrowserStack Env Setup'  # Invokes the setup-env action
+      - name: "BrowserStack Env Setup" # Invokes the setup-env action
         uses: browserstack/github-actions/setup-env@master
         with:
-          username:  ${{ secrets.BROWSERSTACK_USERNAME }}
+          username: ${{ secrets.BROWSERSTACK_USERNAME }}
           access-key: ${{ secrets.BROWSERSTACK_ACCESS_KEY }}
 
-      - name: 'BrowserStack Local Tunnel Setup'  # Invokes the setup-local action
+      - name: "BrowserStack Local Tunnel Setup" # Invokes the setup-local action
         uses: browserstack/github-actions/setup-local@master
         with:
           local-testing: start
           local-identifier: random
 
-      - name: 'Checkout the repository'
+      - name: "Checkout the repository"
         uses: actions/checkout@v4
         with:
           ref: ${{ github.event.pull_request.head.sha }}
           fetch-depth: 2
 
-      - name: 'Setting up Ruby'
-        uses: ruby/setup-ruby@v1
-        # Ruby version is defined in .ruby-version file
-
-      - name: 'Update and Install Dependencies'
+      - name: "Update and Install Dependencies"
         run: |
           sudo apt update
           sudo apt install libcurl4 libcurl4-openssl-dev
-      - name: 'Configure Bundle testing and install gems'
+
+      - name: "Setting up Ruby"
+        uses: ruby/setup-ruby@v1
+        with:
+          bundler-cache: true
+
+      - name: "Configure Bundle testing and install gems"
         run: |
           bundle config unset --local without
-          bundle config set --local with 'test' 'development'
+          bundle config set --local with 'test'
           bundle install
-      - name: 'Run BrowserStack simple verification'
+
+      - name: "Run BrowserStack simple verification"
         run: |
           bundle exec rake browserstack --trace
 
-      - name: 'BrowserStackLocal Stop'  # Terminating the BrowserStackLocal tunnel connection
+      - name: "BrowserStackLocal Stop" # Terminating the BrowserStackLocal tunnel connection
         uses: browserstack/github-actions/setup-local@master
         with:
-          local-testing: stop
+          local-testing: stop

Gemfile

@@ -4,6 +4,8 @@
 # See the file 'doc/COPYING' for copying permission
 #
 
+source 'https://rubygems.org'
+
 gem 'net-smtp', require: false
 gem 'json'
 
@@ -24,7 +26,6 @@ gem 'rake', '~> 13.3'
 gem 'activerecord', '~> 8.1'
 gem 'otr-activerecord', '~> 2.6.0'
 gem 'sqlite3', '~> 2.8'
-gem 'rubocop', '~> 1.81.7', require: false
 
 # Geolocation support
 group :geoip do
@@ -59,6 +60,10 @@ group :ext_qrcode do
   gem 'qr4r', '~> 0.6.1'
 end
 
+group :development do
+  gem 'rubocop', '~> 1.81.7', require: false
+end
+
 # For running unit tests
 group :test do
   gem 'test-unit-full', '~> 0.0.5'
@@ -86,5 +91,3 @@ group :test do
   # sudo port install libxml2 libxslt
   gem 'capybara', '~> 3.40'
 end
-
-source 'https://rubygems.org'