Finalize review comments

Author: orionpapadakis

src/main/java/com/example/model/Configuration.java

@@ -34,7 +34,6 @@ public interface Configuration {
     /** Base value for RoPE (Rotary Position Embedding) calculations */
     float ropeTheta();
 
-    /** Size of each attention head (derived from dim / numberOfHeads) */
     int headSize();
 
     int kvDim();

src/main/java/com/example/model/llama/LlamaConfiguration.java

@@ -15,6 +15,7 @@ public int contextLengthModel() {
         throw new UnsupportedOperationException("Not supported for Llama.");
     }
 
+    /** Size of each attention head (derived from dim / numberOfHeads) */
     public int headSize() {
         return dim / numberOfHeads;
     }

src/main/java/com/example/model/loader/ModelLoader.java

@@ -38,9 +38,9 @@ public abstract class ModelLoader {
     private static final String TOKENIZER_MISTRAL_MODEL = "llama";
 
     protected FileChannel fileChannel;
-    GGUF gguf;
-    int contextLength;
-    boolean loadWeights;
+    protected GGUF gguf;
+    protected int contextLength;
+    protected boolean loadWeights;
 
     public ModelLoader(FileChannel fileChannel, GGUF gguf, int contextLength, boolean loadWeights) {
         this.fileChannel = fileChannel;

src/main/java/com/example/tornadovm/Qwen3TornadoVMLayerPlanner.java

@@ -18,14 +18,13 @@
 
 public class Qwen3TornadoVMLayerPlanner extends TornadoVMLayerPlanner<Qwen3State, Qwen3Configuration, Qwen3TornadoWeights> {
 
-    int nHeadKv;
-    int nEmbdHeadK;
-    int nEmbdHeadV;
-    int nEmbdVGqa;
-    int nEmbdHead;
-    int nEmbdGqa;
-    int gqa;
-    float sqrtHeadSize;
+    private final int nHeadKv;
+    private final int nEmbdHeadK;
+    private final int nEmbdHeadV;
+    private final int nEmbdVGqa;
+    private final int nEmbdHead;
+    private final int nEmbdGqa;
+    private final int gqa;
 
     public Qwen3TornadoVMLayerPlanner(Qwen3State state, Model model) {
         super(state, model);
@@ -37,7 +36,6 @@ public Qwen3TornadoVMLayerPlanner(Qwen3State state, Model model) {
         this.nEmbdHead = nEmbdHeadV;
         this.nEmbdGqa = nEmbdVGqa;
         this.gqa = config.numberOfHeads() / config.numberOfKeyValueHeads(); // integer multiplier of the kv sharing in multiquery
-        this.sqrtHeadSize = (float) Math.sqrt(nEmbdHead);
     }
 
     // @formatter:off