tests: add some basic tests for URN equivalence

Author: sumnerevans

.github/workflows/python.yaml

@@ -49,24 +49,31 @@ jobs:
       run: |
         poetry run cicd/custom_style_check.py
 
-  # test:
-  #   name: Run the tests
-  #   runs-on: ubuntu-latest
-  #   strategy:
-  #     matrix:
-  #       python-version: [ 3.7, 3.8, 3.9 ]
-
-  #   steps:
-  #   - uses: actions/checkout@v2
-  #   - name: Set up Python ${{ matrix.python-version }}
-  #     uses: actions/setup-python@v2
-  #     with:
-  #       python-version: ${{ matrix.python-version }}
-  #   - name: Run image
-  #     uses: abatilo/[email protected]
-  #   - name: Run pytest
-  #     run: |
-  #       poetry run pytest -vv
+  test:
+    name: Run the tests
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        python-version: [ 3.7, 3.8, 3.9 ]
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Python ${{ matrix.python-version }}
+      uses: actions/setup-python@v2
+      with:
+        python-version: ${{ matrix.python-version }}
+    - name: Run image
+      uses: abatilo/[email protected]
+    - name: Install dependencies
+      run: |
+        poetry install
+    - name: Run pytest
+      run: |
+        poetry run pytest -vv
+        poetry run pytest -vv > pytest-coverage.txt
+    - name: Comment coverage
+      uses: coroo/[email protected]
+      if: ${{ matrix.python-version == '3.9' && github.event_name == 'pull_request' && github.event.action == 'created' }}
 
   build:
     name: Build linkedin_messaging
@@ -90,7 +97,7 @@ jobs:
   deploy:
     name: Deploy to pypi
     runs-on: ubuntu-latest
-    needs: [lint, build]
+    needs: [lint, test, build]
     if: ${{ github.event_name == 'release' && github.event.action == 'created' }}
 
     steps:

linkedin_messaging/api_objects.py

@@ -35,6 +35,11 @@ def __str__(self):
             ),
         )
 
+    def __eq__(self, other: Any):
+        if not isinstance(other, URN):
+            return False
+        return self.id_parts == other.id_parts
+
     def __repr__(self):
         return f"URN('{str(self)}')"
 

poetry.lock

@@ -41,6 +41,18 @@ jedi = "^0.17.2"
 mypy = "^0.782"
 pytest = "^6.2.4"
 termcolor = "^1.1.0"
+pytest-cov = "^2.12.1"
+
+[tool.pytest.ini_options]
+addopts = """
+    -vvv
+    --doctest-modules
+    --ignore-glob='examples/*'
+    --ignore-glob='cicd/*'
+    --cov=linkedin_messaging
+    --cov-report html
+    --cov-report term
+"""
 
 [build-system]
 requires = ["poetry>=0.12"]

pyproject.toml

@@ -0,0 +1,13 @@
+from linkedin_messaging import URN
+
+
+def test_urn_equivalence():
+    assert URN("urn:123") == URN("123")
+    assert URN("urn:(123,456)") == URN("urn:test:(123,456)")
+
+
+def test_urn_equivalence_in_tuple():
+    assert (URN("urn:123"), URN("urn:(123,456)")) == (
+        URN("123"),
+        URN("urn:test:(123,456)"),
+    )