Skip to content
This repository was archived by the owner on Mar 26, 2024. It is now read-only.

Commit 1870259

Browse files
committed
Add missing RedisLruCache.get_external method
1 parent 53f644b commit 1870259

File tree

1 file changed

+11
-4
lines changed

1 file changed

+11
-4
lines changed

synapse/util/caches/redis_caches.py

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,18 @@ async def get(
5555
if local_value is not default:
5656
return local_value
5757

58-
redis_value = await self.redis_shard_cache.get(self.cache_name, _redis_key(key))
59-
if redis_value:
60-
await super().set(key, redis_value)
61-
return redis_value
58+
return await self.get_external(key, default, update_metrics=update_metrics)
6259

60+
async def get_external(
61+
self,
62+
key: KT,
63+
default: Optional[T] = None,
64+
update_metrics: bool = True,
65+
) -> Union[None, VT, T]:
66+
value = await self.redis_shard_cache.get(self.cache_name, _redis_key(key))
67+
if value is not default:
68+
self.set_local(key, value)
69+
return value
6370
return default
6471

6572
async def set(self, key: KT, value: Any) -> None:

0 commit comments

Comments
 (0)