Calculate rooms changed for device lists to work. (matrix-org#14810)

Back-out some changes from 7e582a2
(matrix-org#14786) which skipped necessary logic to calculate device lists properly.

Author: clokep

changelog.d/14810.bugfix

@@ -0,0 +1 @@
+Fix a bug introduced in Synapse 1.75.0rc1 where device lists could be miscalculated with some sync filters.

synapse/api/filtering.py

@@ -283,9 +283,6 @@ async def filter_room_account_data(
             await self._room_filter.filter(events)
         )
 
-    def blocks_all_rooms(self) -> bool:
-        return self._room_filter.filters_all_rooms()
-
     def blocks_all_presence(self) -> bool:
         return (
             self._presence_filter.filters_all_types()

synapse/handlers/sync.py

@@ -1793,10 +1793,6 @@ async def _generate_sync_entry_for_rooms(
             - newly_left_users
         """
 
-        # If the request doesn't care about rooms then nothing to do!
-        if sync_result_builder.sync_config.filter_collection.blocks_all_rooms():
-            return set(), set(), set(), set()
-
         since_token = sync_result_builder.since_token
 
         # 1. Start by fetching all ephemeral events in rooms we've joined (if required).