Remove undocumented device from pushrules (matrix-org#14727)

JeyRathnam · David Robertson · web-flow · commit 58d2adc3da6a · 2023-01-09T17:17:24.000Z
* Remove undocumented device from pushrules

* Add changelog

* Update changelog.d/14727.misc

* Rename 14727.misc to 14727.bugfix

Co-authored-by: David Robertson &lt;davidr@element.io&gt;
diff --git a/changelog.d/14727.bugfix b/changelog.d/14727.bugfix
@@ -0,0 +1 @@
+Remove the unspecced `device` field from `/pushrules` responses.
diff --git a/synapse/push/clientformat.py b/synapse/push/clientformat.py
@@ -26,10 +26,7 @@ def format_push_rules_for_user(
     """Converts a list of rawrules and a enabled map into nested dictionaries
     to match the Matrix client-server format for push rules"""
 
-    rules: Dict[str, Dict[str, List[Dict[str, Any]]]] = {
-        "global": {},
-        "device": {},
-    }
+    rules: Dict[str, Dict[str, List[Dict[str, Any]]]] = {"global": {}}
 
     rules["global"] = _add_empty_priority_class_arrays(rules["global"])
 

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Remove the unspecced `device` field from `/pushrules` responses.