Fix bug in bulk push rule evaluation when related events that don't yet exist

Fizzadar · Fizzadar · commit dc854246d07a · 2022-06-15T16:07:09.000+01:00
diff --git a/synapse/push/bulk_push_rule_evaluator.py b/synapse/push/bulk_push_rule_evaluator.py
@@ -266,7 +266,7 @@ async def action_for_event_by_user(
 
         related_event_id = event.content.get("m.relates_to", {}).get("event_id")
         related_event = (
-            (await self.store.get_event(related_event_id)) if related_event_id else None
+            (await self.store.get_event(related_event_id, allow_none=True)) if related_event_id else None
         )
 
         non_bot_room_members = [x for x in room_members if not BOT_PATTERN.match(x)]

Original file line number	Diff line number	Diff line change
`@@ -266,7 +266,7 @@ async def action_for_event_by_user(`
`266`	`266`
`267`	`267`	`related_event_id = event.content.get("m.relates_to", {}).get("event_id")`
`268`	`268`	`related_event = (`
`269`		`- (await self.store.get_event(related_event_id)) if related_event_id else None`
	`269`	`+ (await self.store.get_event(related_event_id, allow_none=True)) if related_event_id else None`
`270`	`270`	`)`
`271`	`271`
`272`	`272`	`non_bot_room_members = [x for x in room_members if not BOT_PATTERN.match(x)]`