Do not call str inside f-string

Author: snejus

beets/ui/commands.py

@@ -113,13 +113,11 @@ def _parse_logfiles(logfiles):
             yield from _paths_from_logfile(syspath(normpath(logfile)))
         except ValueError as err:
             raise ui.UserError(
-                f"malformed logfile {util.displayable_path(logfile)}:"
-                f" {str(err)}"
+                f"malformed logfile {util.displayable_path(logfile)}: {err}"
             ) from err
         except OSError as err:
             raise ui.UserError(
-                f"unreadable logfile {util.displayable_path(logfile)}:"
-                f" {str(err)}"
+                f"unreadable logfile {util.displayable_path(logfile)}: {err}"
             ) from err
 
 
@@ -212,7 +210,7 @@ def get_singleton_disambig_fields(info: hooks.TrackInfo) -> Sequence[str]:
     out = []
     chosen_fields = config["match"]["singleton_disambig_fields"].as_str_seq()
     calculated_values = {
-        "index": f"Index {str(info.index)}",
+        "index": f"Index {info.index}",
         "track_alt": f"Track {info.track_alt}",
         "album": (
             f"[{info.album}]"

beets/util/__init__.py

@@ -112,7 +112,7 @@ def _reasonstr(self):
         elif hasattr(self.reason, "strerror"):  # i.e., EnvironmentError
             return self.reason.strerror
         else:
-            return f'"{str(self.reason)}"'
+            return f'"{self.reason}"'
 
     def get_message(self):
         """Create the human-readable description of the error, sans

beetsplug/bpd/__init__.py

@@ -1138,7 +1138,7 @@ def _item_info(self, item):
             pass
 
         for tagtype, field in self.tagtype_map.items():
-            info_lines.append(f"{tagtype}: {str(getattr(item, field))}")
+            info_lines.append(f"{tagtype}: {getattr(item, field)}")
 
         return info_lines
 
@@ -1297,15 +1297,12 @@ def cmd_status(self, conn):
 
             yield (
                 f"bitrate: {item.bitrate / 1000}",
-                (
-                    "audio:"
-                    f" {str(item.samplerate)}:{str(item.bitdepth)}:{str(item.channels)}"
-                ),
+                f"audio: {item.samplerate}:{item.bitdepth}:{item.channels}",
             )
 
             (pos, total) = self.player.time()
             yield (
-                f"time: {str(int(pos))}:{str(int(total))}",
+                f"time: {int(pos)}:{int(total)}",
                 "elapsed: {pos:.3f}",
                 "duration: {total:.3f}",
             )