Fix handling of commas and semicolons in artist join

Author: henry-oberholtzer

beetsplug/discogs.py

@@ -476,7 +476,11 @@ def _join_artist(self, base: str, artist: str, join: str) -> str:
             base = artist
         else:
             if join:
-                base += f" {join} "
+                join = join.strip()
+                if join in ";,":
+                    base += f"{join} "
+                else:
+                    base += f" {join} "
             else:
                 base += ", "
             base += artist

test/plugins/test_discogs.py

@@ -464,14 +464,14 @@ def test_strip_disambiguation_false(self):
     "track_artist_anv,track_artist,track_artists",
     [
         (False, "ARTIST Feat. PERFORMER", ["ARTIST", "PERFORMER"]),
-        (True, "VARIATION Feat. VARIATION", ["VARIATION", "VARIATION"]),
+        (True, "ART Feat. PERF", ["ART", "PERF"]),
     ],
 )
 @pytest.mark.parametrize(
     "album_artist_anv,album_artist,album_artists",
     [
-        (False, "ARTIST & SOLOIST", ["ARTIST", "SOLOIST"]),
-        (True, "VARIATION & VARIATION", ["VARIATION", "VARIATION"]),
+        (False, "DRUMMER, ARTIST & SOLOIST", ["DRUMMER", "ARTIST", "SOLOIST"]),
+        (True, "DRUM, ARTY & SOLO", ["DRUM", "ARTY", "SOLO"]),
     ],
 )
 @pytest.mark.parametrize(
@@ -484,15 +484,15 @@ def test_strip_disambiguation_false(self):
             False,
             "ARTIST Feat. PERFORMER",
             ["ARTIST", "PERFORMER"],
-            "ARTIST & SOLOIST",
-            ["ARTIST", "SOLOIST"],
+            "DRUMMER, ARTIST & SOLOIST",
+            ["DRUMMER", "ARTIST", "SOLOIST"],
         ),
         (
             True,
-            "VARIATION Feat. VARIATION",
-            ["VARIATION", "VARIATION"],
-            "VARIATION & VARIATION",
-            ["VARIATION", "VARIATION"],
+            "ART Feat. PERF",
+            ["ART", "PERF"],
+            "DRUM, ARTY & SOLO",
+            ["DRUM", "ARTY", "SOLO"],
         ),
     ],
 )
@@ -524,23 +524,24 @@ def test_anv(
                     {
                         "name": "ARTIST",
                         "tracks": "",
-                        "anv": "VARIATION",
+                        "anv": "ART",
                         "id": 11146,
                     }
                 ],
                 "extraartists": [
                     {
                         "name": "PERFORMER",
                         "role": "Featuring",
-                        "anv": "VARIATION",
+                        "anv": "PERF",
                         "id": 787,
                     }
                 ],
             }
         ],
         "artists": [
-            {"name": "ARTIST (4)", "anv": "VARIATION", "id": 321, "join": "&"},
-            {"name": "SOLOIST", "anv": "VARIATION", "id": 445, "join": ""},
+            {"name": "DRUMMER", "anv": "DRUM", "id": 445, "join": ", "},
+            {"name": "ARTIST (4)", "anv": "ARTY", "id": 321, "join": "&"},
+            {"name": "SOLOIST", "anv": "SOLO", "id": 445, "join": ""},
         ],
         "title": "title",
     }