fix(lastgenre): Reset plugin config in fixtured tests

Fixes a bug in the lastgenre, where test state bled into the following fixtures.

Each plugin has a view to the global persisted beets.config field. As a result,
variables that aren't explicitly overwritten are persisted in that global config view.

This commit exposes the default config as a static method and uses that default
config to reset the state in between fixture calls.

There were 5 tests that depended on count: 10 being set on previous test fixtures,
which I adjusted accordingly.

Author: Nukesor

beetsplug/lastgenre/__init__.py

@@ -100,25 +100,27 @@ class LastGenrePlugin(plugins.BeetsPlugin):
     def __init__(self) -> None:
         super().__init__()
 
-        self.config.add(
-            {
-                "whitelist": True,
-                "min_weight": 10,
-                "count": 1,
-                "fallback": None,
-                "canonical": False,
-                "source": "album",
-                "force": False,
-                "keep_existing": False,
-                "auto": True,
-                "separator": ", ",
-                "prefer_specific": False,
-                "title_case": True,
-                "pretend": False,
-            }
-        )
+        self.config.add(LastGenrePlugin.default_configuration())
         self.setup()
 
+    @staticmethod
+    def default_configuration() -> dict[str, Any]:
+        return {
+            "whitelist": True,
+            "min_weight": 10,
+            "count": 1,
+            "fallback": None,
+            "canonical": False,
+            "source": "album",
+            "force": False,
+            "keep_existing": False,
+            "auto": True,
+            "separator": ", ",
+            "prefer_specific": False,
+            "title_case": True,
+            "pretend": False,
+        }
+
     def setup(self) -> None:
         """Setup plugin from config options"""
         if self.config["auto"]:

test/plugins/test_lastgenre.py

@@ -230,6 +230,7 @@ def test_sort_by_depth(self):
                 "whitelist": True,
                 "canonical": False,
                 "prefer_specific": False,
+                "count": 10,
             },
             "original unknown, Blues",
             {
@@ -262,6 +263,7 @@ def test_sort_by_depth(self):
                 "whitelist": True,
                 "canonical": False,
                 "prefer_specific": False,
+                "count": 10,
             },
             "original unknown, Blues",
             {
@@ -311,6 +313,7 @@ def test_sort_by_depth(self):
                 "whitelist": False,
                 "canonical": False,
                 "prefer_specific": False,
+                "count": 10,
             },
             "unknown genre",
             {
@@ -409,6 +412,7 @@ def test_sort_by_depth(self):
                 "separator": "\u0000",
                 "canonical": False,
                 "prefer_specific": False,
+                "count": 10,
             },
             "Blues",
             {
@@ -590,6 +594,7 @@ def mock_fetch_artist_genre(self, artist):
     # Initialize plugin instance and item
     plugin = lastgenre.LastGenrePlugin()
     # Configure
+    plugin.config.set(lastgenre.LastGenrePlugin.default_configuration())
     plugin.config.set(config_values)
     plugin.setup()  # Loads default whitelist and canonicalization tree
     item = _common.item()