Skip to content

Commit 5900282

Browse files
committed
Use BeetsTestCase for lastgenre tests, re-use the defined config
1 parent c9f98fc commit 5900282

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

test/plugins/test_lastgenre.py

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -14,30 +14,29 @@
1414

1515
"""Tests for the 'lastgenre' plugin."""
1616

17-
import unittest
1817
from unittest.mock import Mock
1918

2019
import pytest
2120

22-
from beets import config
2321
from beets.test import _common
22+
from beets.test.helper import BeetsTestCase
2423
from beetsplug import lastgenre
2524

2625

27-
class LastGenrePluginTest(unittest.TestCase):
26+
class LastGenrePluginTest(BeetsTestCase):
2827
def setUp(self):
2928
super().setUp()
3029
self.plugin = lastgenre.LastGenrePlugin()
3130

3231
def _setup_config(
3332
self, whitelist=False, canonical=False, count=1, prefer_specific=False
3433
):
35-
config["lastgenre"]["canonical"] = canonical
36-
config["lastgenre"]["count"] = count
37-
config["lastgenre"]["prefer_specific"] = prefer_specific
34+
self.config["lastgenre"]["canonical"] = canonical
35+
self.config["lastgenre"]["count"] = count
36+
self.config["lastgenre"]["prefer_specific"] = prefer_specific
3837
if isinstance(whitelist, (bool, (str,))):
3938
# Filename, default, or disabled.
40-
config["lastgenre"]["whitelist"] = whitelist
39+
self.config["lastgenre"]["whitelist"] = whitelist
4140
self.plugin.setup()
4241
if not isinstance(whitelist, (bool, (str,))):
4342
# Explicit list of genres.
@@ -463,11 +462,10 @@ def mock_fetch_artist_genre(self, obj):
463462
lastgenre.LastGenrePlugin.fetch_album_genre = mock_fetch_album_genre
464463
lastgenre.LastGenrePlugin.fetch_artist_genre = mock_fetch_artist_genre
465464

466-
# Configure
467-
config["lastgenre"] = config_values
468-
469465
# Initialize plugin instance and item
470466
plugin = lastgenre.LastGenrePlugin()
467+
# Configure
468+
plugin.config.set(config_values)
471469
item = _common.item()
472470
item.genre = item_genre
473471

0 commit comments

Comments
 (0)