Skip to content

Commit 96c5121

Browse files
committed
Documentation for #1555/#1556
1 parent 4818264 commit 96c5121

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

beetsplug/fetchart.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -437,6 +437,8 @@ def _fetch_image(self, url):
437437
util.displayable_path(fh.name))
438438
return fh.name
439439
except (IOError, requests.RequestException, TypeError):
440+
# Handling TypeError works around a urllib3 bug:
441+
# https://github.com/shazow/urllib3/issues/556
440442
self._log.debug(u'error fetching art')
441443

442444
def _is_valid_image_candidate(self, candidate):

docs/changelog.rst

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,8 @@ Fixes:
8383
plugin-provided ones. This distinction was becoming increasingly unreliable.
8484
* :doc:`/plugins/duplicates`: Fix a Unicode warning when paths contained
8585
non-ASCII characters. :bug:`1551`
86+
* :doc:`/plugins/fetchart`: Work around a urllib3 bug that could cause a
87+
crash. :bug:`1555` :bug:`1556`
8688

8789
.. _Python bug: http://bugs.python.org/issue16512
8890

0 commit comments

Comments
 (0)