Help me understand the album fields

[HOZHENWAI]

So I've written a plugin the integrate VGMdb (https://vgmdb.net/) as metadata source:
https://github.com/HOZHENWAI/Beets-Plugin_VGMdb
This also include a plugin to manage a collection automatically on vgmdb if you have an account.
It works on my developpement computer (I cloned the main beets repo and I had no issue getting the metadata and adding/removing albums)
This issue I have is on a remote server where I installed a beets instance (1.6.0).
I had issue adding/removing albums on import (using a listerner that listen to album_imported event)
Strangely, I have a "data_source" field not found error that I can't reproduce on my developpement computer.

[sampsyo]

That's odd. Can you include a complete traceback? I'm not sure how to dig into this otherwise…

[HOZHENWAI]

Result of beet --version:
/usr/local/lib/python3.9/dist-packages/beets/mediafile.py:19: UserWarning: beets.mediafile is deprecated; use mediafile instead
warnings.warn("beets.mediafile is deprecated; use mediafile instead")
VGMCollection: Successfully logged into VGMdb
beets version 1.6.0
Python version 3.9.5
plugins: VGMCollection, VGMplug, acousticbrainz, badfiles, check, chroma, copyartifacts, duplicates, embedart, fetchart, lyrics, mbcollection, mbsync, missing, plexupdate, web

Traceback:

Traceback (most recent call last):
File "/usr/local/lib/python3.9/dist-packages/beets/dbcore/db.py", line 483, in getattr
return self[key]
File "/usr/local/lib/python3.9/dist-packages/beets/dbcore/db.py", line 390, in getitem
return self.get(key, raise=True)
File "/usr/local/lib/python3.9/dist-packages/beets/dbcore/db.py", line 380, in _get
raise KeyError(key)
KeyError: 'data_source'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "/usr/local/bin/beet", line 8, in
sys.exit(main())
File "/usr/local/lib/python3.9/dist-packages/beets/ui/init.py", line 1285, in main
_raw_main(args)
File "/usr/local/lib/python3.9/dist-packages/beets/ui/init.py", line 1272, in _raw_main
subcommand.func(lib, suboptions, subargs)
File "/usr/local/lib/python3.9/dist-packages/beets/ui/commands.py", line 973, in import_func
import_files(lib, paths, query)
File "/usr/local/lib/python3.9/dist-packages/beets/ui/commands.py", line 943, in import_files
session.run()
File "/usr/local/lib/python3.9/dist-packages/beets/importer.py", line 340, in run
pl.run_parallel(QUEUE_SIZE)
File "/usr/local/lib/python3.9/dist-packages/beets/util/pipeline.py", line 446, in run_parallel
raise exc_info[1].with_traceback(exc_info[2])
File "/usr/local/lib/python3.9/dist-packages/beets/util/pipeline.py", line 358, in run
self.coro.send(msg)
File "/usr/local/lib/python3.9/dist-packages/beets/util/pipeline.py", line 170, in coro
task = func(*(args + (task,)))
File "/usr/local/lib/python3.9/dist-packages/beets/importer.py", line 1573, in manipulate_files
task.finalize(session)
File "/usr/local/lib/python3.9/dist-packages/beets/importer.py", line 612, in finalize
self._emit_imported(session.lib)
File "/usr/local/lib/python3.9/dist-packages/beets/importer.py", line 638, in _emit_imported
plugins.send('album_imported', lib=lib, album=self.album)
File "/usr/local/lib/python3.9/dist-packages/beets/plugins.py", line 488, in send
result = handler(**arguments)
File "/usr/local/lib/python3.9/dist-packages/beets/plugins.py", line 145, in wrapper
return func(*args, **kwargs)
File "/usr/local/lib/python3.9/dist-packages/beetsplug/VGMCollection.py", line 53, in album_imported
if album.data_source == self.data_source:
File "/usr/local/lib/python3.9/dist-packages/beets/dbcore/db.py", line 485, in getattr
raise AttributeError(f'no such field {key!r}')
AttributeError: no such field 'data_source'

[wisp3rwind]

Well, the data_source field is a flexible attribute, it is not guaranteed to exist (for example for as-is imports or if your new metadata source doesn't always set it). The plugin needs to be able to deal with this field being unset. Maybe on the remote, beets fails to connect to vgmdb and this somehow results in an incomplete import without this field being set?

[sampsyo]

You might try album.get('data_source'), for example, to deal with albums that don't have this set (and to return false from the equality test).