Is test_nonexistant_db supposed to ask for feedback?

[Phil305]

Hey, I ran the tests for this project via python testall.py (as explained in here), and I noticed that the test_nonexistant_dbtest in test_ui.py asks me for feedback... I'm curious, is that supposed to happen, or are all the unittests supposed to run fully-auto w/o any user input?

My environment:
OS

ProductName:		macOS
ProductVersion:		14.1.1
BuildVersion:		23B81

beets version: 1.6.1
Python version: 3.11.6

Here's a screenshot of what I'm seeing:

[sampsyo]

That's odd! It does look like a problem. This test works fine if I run the whole file's suite (e.g., pytest test/test_ui.py) but not if I run just that one test alone (pytest -k nonex test/test_ui.py):

============================= test session starts ==============================
platform darwin -- Python 3.11.6, pytest-7.4.3, pluggy-1.3.0
rootdir: /Users/fabian/Documents/code/beets
collected 132 items / 131 deselected / 1 selected                              

test/test_ui.py F                                                        [100%]

=================================== FAILURES ===================================
________________________ ConfigTest.test_nonexistant_db ________________________

self = <test.test_ui.ConfigTest testMethod=test_nonexistant_db>

    def test_nonexistant_db(self):
        with self.write_config_file() as config:
            config.write("library: /xxx/yyy/not/a/real/path")
    
        with self.assertRaises(ui.UserError):
>           self.run_command("test", lib=None)

test/test_ui.py:940: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
test/helper.py:457: in run_command
    beets.ui._raw_main(_convert_args(list(args)), lib)
beets/ui/__init__.py:1848: in _raw_main
    subcommands, plugins, lib = _setup(options, lib)
beets/ui/__init__.py:1697: in _setup
    lib = _open_library(config)
beets/ui/__init__.py:1757: in _open_library
    _ensure_db_directory_exists(dbpath)
beets/ui/__init__.py:1745: in _ensure_db_directory_exists
    if input_yn(
beets/ui/__init__.py:393: in input_yn
    sel = input_options(("y", "n"), require, prompt, yesno)
beets/ui/__init__.py:354: in input_options
    resp = input_(prompt)
beets/ui/__init__.py:202: in input_
    resp = input()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

    def read(self, size: int = -1) -> str:
>       raise OSError(
            "pytest: reading from stdin while output is captured!  Consider using `-s`."
        )
E       OSError: pytest: reading from stdin while output is captured!  Consider using `-s`.

../../../Library/Python/3.11/lib/python/site-packages/_pytest/capture.py:202: OSError
----------------------------- Captured stdout call -----------------------------
The database directory /xxx/yyy/not/a/real does not                        exist. Create it (Y/n)? 
=============================== warnings summary ===============================
../mediafile/mediafile.py:50
  /Users/fabian/Documents/code/mediafile/mediafile.py:50: DeprecationWarning: 'imghdr' is deprecated and slated for removal in Python 3.13
    import imghdr

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================== short test summary info ============================
FAILED test/test_ui.py::ConfigTest::test_nonexistant_db - OSError: pytest: reading from stdin while output is captured!  Consider usi...
================= 1 failed, 131 deselected, 1 warning in 0.35s =================

So there is almost certainly some kind of hidden ordering dependency here that is causing stdin to be controlled even though the test does not directly demand it. Worth looking into!

[Phil305]

Hey @sampsyo, here's a diff: #5027

Could you check that it fixes the issue on your machine? I didn't actually look for a root cause for the original issue, so I'm not totally convinced it'll work on yours too, but if it does, then I'm happy 🙂