Skip to content

Commit 4958e73

Browse files
committed
fix
1 parent 9df4f2f commit 4958e73

File tree

4 files changed

+19
-18
lines changed

4 files changed

+19
-18
lines changed

src/Services/Basket/Basket.API.IntegrationTests/ApiSpecification.cs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ public class GetWebApiContainerFactory : ICollectionFixture<ApiSpecification>
1616
}
1717
public class ApiSpecification : IAsyncLifetime
1818
{
19-
private readonly CancellationTokenSource _timeoutCancellationTokenSource = new(TimeSpan.FromSeconds(40));
2019
private IDistributedCache? _cache;
2120
private WireMockServer? _discountWireMockServer;
2221
private ApiFactory? _factory;
@@ -31,7 +30,6 @@ internal HttpClient HttpClient
3130
get
3231
{
3332
var client = _httpClient ??= _factory!.CreateClient();
34-
_httpClient.Timeout = TimeSpan.FromMinutes(2);
3533
client.ClearDefaultHeaders();
3634
return client;
3735
}
@@ -41,7 +39,10 @@ internal HttpClient HttpClient
4139
_postgresDataSeeder ??= new PostgresDataSeeder(GetDocumentStore());
4240

4341
internal RedisDataSeeder RedisDataSeeder => _redisDataSeeder ??= new RedisDataSeeder(GetCache());
44-
internal CancellationToken CancellationToken => _timeoutCancellationTokenSource.Token;
42+
internal CancellationToken CreateTimeoutToken(int seconds = 120)
43+
{
44+
return new CancellationTokenSource(TimeSpan.FromSeconds(seconds)).Token;
45+
}
4546

4647
public void ResetWireMockServer()
4748
{
@@ -70,7 +71,7 @@ public async Task DisposeAsync()
7071
await _factory.DisposeAsync();
7172

7273
_httpClient?.Dispose();
73-
_store?.Advanced.ResetAllData(CancellationToken);
74+
_store?.Advanced.ResetAllData(CreateTimeoutToken());
7475
_store?.Dispose();
7576
await _webApiContainer.DisposeAsync();
7677
_discountWireMockServer?.Stop();

src/Services/Basket/Basket.API.IntegrationTests/Features/DeleteBasket/DeleteBasketTests.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public DeleteBasketTests(ApiSpecification apiSpecification) : base(apiSpecificat
2222
public async Task DeleteBasket_No_Token_Returns_Unauthorized(string username)
2323
{
2424
// Arrange
25-
var timeout = _apiSpecification.CancellationToken;
25+
var timeout = _apiSpecification.CreateTimeoutToken();
2626

2727
// Act
2828
var result = await _client
@@ -37,7 +37,7 @@ public async Task DeleteBasket_No_Token_Returns_Unauthorized(string username)
3737
public async Task DeleteBasket_No_Permission_Returns_Forbidden(string username)
3838
{
3939
// Arrange
40-
var timeout = _apiSpecification.CancellationToken;
40+
var timeout = _apiSpecification.CreateTimeoutToken();
4141

4242
// Act
4343
var result = await _client
@@ -52,7 +52,7 @@ public async Task DeleteBasket_No_Permission_Returns_Forbidden(string username)
5252
public async Task DeleteBasket_Deletes_Basket_From_Cache_And_PostgresDb_Returns_Ok()
5353
{
5454
// Arrange
55-
var timeout = _apiSpecification.CancellationToken;
55+
var timeout = _apiSpecification.CreateTimeoutToken();
5656
var username = "test username 1";
5757

5858
var shoppingCart = new ShoppingCart

src/Services/Basket/Basket.API.IntegrationTests/Features/GetBasket/GetBasketTests.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public GetBasketTests(ApiSpecification apiSpecification) : base(apiSpecification
2020
public async Task GetBasket_No_Token_Returns_Unauthorized()
2121
{
2222
// Arrange
23-
var timeout = _apiSpecification.CancellationToken;
23+
var timeout = _apiSpecification.CreateTimeoutToken();
2424
const string username = "test username 1";
2525

2626
// Act
@@ -35,7 +35,7 @@ public async Task GetBasket_No_Token_Returns_Unauthorized()
3535
public async Task GetBasket_No_Permission_Returns_Forbidden()
3636
{
3737
// Arrange
38-
var timeout = _apiSpecification.CancellationToken;
38+
var timeout = _apiSpecification.CreateTimeoutToken();
3939
const string username = "test username 1";
4040

4141
// Act
@@ -51,7 +51,7 @@ public async Task GetBasket_No_Permission_Returns_Forbidden()
5151
public async Task GetBasket_Basket_NotFound_Returns_NotFound()
5252
{
5353
// Arrange
54-
var timeout = _apiSpecification.CancellationToken;
54+
var timeout = _apiSpecification.CreateTimeoutToken();
5555
const string username = "test username 1";
5656

5757
// Act
@@ -73,7 +73,7 @@ public async Task GetBasket_Basket_NotFound_Returns_NotFound()
7373
public async Task GetBasket_Basket_Only_Exists_In_Postgres_database_Should_Return_Basket_And_Add_To_Redis()
7474
{
7575
// Arrange
76-
var timeout = _apiSpecification.CancellationToken;
76+
var timeout = _apiSpecification.CreateTimeoutToken();
7777
const string username = "test username 2";
7878

7979
var shoppingCart = new ShoppingCart
@@ -121,7 +121,7 @@ public async Task GetBasket_Basket_Only_Exists_In_Postgres_database_Should_Retur
121121
public async Task GetBasket_Basket_Only_Exists_In_Redis_database_Should_Return_Basket()
122122
{
123123
// Arrange
124-
var timeout = _apiSpecification.CancellationToken;
124+
var timeout = _apiSpecification.CreateTimeoutToken();
125125
const string username = "test username 3";
126126

127127
var shoppingCart = new ShoppingCart

src/Services/Basket/Basket.API.IntegrationTests/Features/StoreBasket/StoreBasketTests.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public StoreBasketTests(ApiSpecification apiSpecification) : base(apiSpecificati
2525
public async Task StoreBasket_Null_Username_Returns_BadRequest(StoreBasketRequest request)
2626
{
2727
// Arrange
28-
var token = _apiSpecification.CancellationToken;
28+
var token = _apiSpecification.CreateTimeoutToken();
2929
var invalidRequest =
3030
new StoreBasketRequest(new BasketDtoRequest(string.Empty, request.ShoppingCart!.Items));
3131

@@ -50,7 +50,7 @@ public async Task StoreBasket_Null_Username_Returns_BadRequest(StoreBasketReques
5050
public async Task StoreBasket_Null_Request_Returns_BadRequest(StoreBasketRequest request)
5151
{
5252
// Arrange
53-
var token = _apiSpecification.CancellationToken;
53+
var token = _apiSpecification.CreateTimeoutToken();
5454
request = new StoreBasketRequest(null);
5555

5656
// Act
@@ -97,7 +97,7 @@ public async Task StoreBasket_Null_Items_In_Request_Returns_BadRequest(StoreBask
9797
public async Task StoreBasket_Zero_Quantity_In_Items_In_Request_Returns_BadRequest(StoreBasketRequest request)
9898
{
9999
// Arrange
100-
var token = _apiSpecification.CancellationToken;
100+
var token = _apiSpecification.CreateTimeoutToken();
101101
var invalidRequest =
102102
new StoreBasketRequest(new BasketDtoRequest(
103103
request.ShoppingCart!.Username,
@@ -123,7 +123,7 @@ public async Task StoreBasket_Zero_Quantity_In_Items_In_Request_Returns_BadReque
123123
public async Task StoreBasket_Zero_Price_In_Items_In_Request_Returns_BadRequest(StoreBasketRequest request)
124124
{
125125
// Arrange
126-
var token = _apiSpecification.CancellationToken;
126+
var token = _apiSpecification.CreateTimeoutToken();
127127
var invalidRequest =
128128
new StoreBasketRequest(new BasketDtoRequest(
129129
request.ShoppingCart!.Username,
@@ -149,7 +149,7 @@ public async Task StoreBasket_Zero_Price_In_Items_In_Request_Returns_BadRequest(
149149
public async Task StoreBasket_Valid_Request_Saves_Data_In_PostgresDb_And_Redis(StoreBasketRequest request)
150150
{
151151
// Arrange
152-
var token = _apiSpecification.CancellationToken;
152+
var token = _apiSpecification.CreateTimeoutToken();
153153
_discountGiven.GetDiscountGiven(request.ShoppingCart!.Items!.FirstOrDefault()!.ProductName);
154154

155155
// Act
@@ -183,7 +183,7 @@ public async Task StoreBasket_Valid_Request_Saves_Data_In_PostgresDb_And_Redis(S
183183
public async Task StoreBasket_Valid_Request_Saves_Data_With_Valid_TotalPrice(StoreBasketRequest request)
184184
{
185185
// Arrange
186-
var token = _apiSpecification.CancellationToken;
186+
var token = _apiSpecification.CreateTimeoutToken();
187187
var validRequest = new StoreBasketRequest(new BasketDtoRequest(request.ShoppingCart!.Username,
188188
new List<BasketItem>
189189
{

0 commit comments

Comments
 (0)