Skip to content

Commit fa6a66a

Browse files
committed
Rename required extension to .basisu.ktx2
1 parent ca65b26 commit fa6a66a

16 files changed

+72
-17
lines changed

.gitattributes

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
*.ktx2 filter=lfs diff=lfs merge=lfs -text
2-
*.basisu_ktx2 filter=lfs diff=lfs merge=lfs -text
32
vendor/basis_universal/**/* filter=lfs diff=lfs merge=lfs -text
43
*.wasm filter=lfs diff=lfs merge=lfs -text

.github/workflows/ci.yml

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,45 @@ env:
1616
EM_VERSION: 4.0.22
1717

1818
jobs:
19+
toml:
20+
runs-on: ubuntu-latest
21+
timeout-minutes: 30
22+
steps:
23+
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
24+
with:
25+
persist-credentials: false
26+
- name: Install taplo
27+
run: curl -fsSL https://github.com/tamasfe/taplo/releases/download/0.10.0/taplo-linux-x86_64.gz | gzip -d - | install -m 755 /dev/stdin /usr/local/bin/taplo
28+
- name: Run Taplo
29+
id: taplo
30+
run: taplo fmt --check --diff
31+
- name: Taplo info
32+
if: failure()
33+
run: |
34+
echo 'To fix toml fmt, please run `taplo fmt`.'
35+
echo 'To check for a diff, run `taplo fmt --check --diff`.'
36+
echo 'You can find taplo here: https://taplo.tamasfe.dev/'
37+
echo 'Or if you use VSCode, use the `Even Better Toml` extension.'
38+
echo 'You can find the extension here: https://marketplace.visualstudio.com/items?itemName=tamasfe.even-better-toml'
39+
40+
typos:
41+
runs-on: ubuntu-latest
42+
timeout-minutes: 30
43+
steps:
44+
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
45+
with:
46+
persist-credentials: false
47+
- name: Check for typos
48+
uses: crate-ci/typos@ad3053d3adbcce7f2e3c60fd4ddfc239787d1eff # v1.43.2
49+
- name: Typos info
50+
if: failure()
51+
run: |
52+
echo 'To fix typos, please run `typos -w`'
53+
echo 'To check for a diff, run `typos`'
54+
echo 'You can find typos here: https://crates.io/crates/typos'
55+
echo 'if you use VSCode, you can also install `Typos Spell Checker'
56+
echo 'You can find the extension here: https://marketplace.visualstudio.com/items?itemName=tekumara.typos-vscode'
57+
1958
build-linux-wasm:
2059
name: Build linux,wasm
2160
runs-on: ubuntu-latest

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,10 @@ pub fn main() {
3939

4040
1. Load ktx2 basis universal textures. Supports `D2`, `D2Array` and `Cube` texture types. Only supports KTX2 format (zstd compression is supported). No support for `.basis` format.
4141
```rs
42-
let image_handle = asset_server.load("gl_skybox_etc1s_cubemap_mips_12.basisu_ktx2");
42+
let image_handle = asset_server.load("gl_skybox_etc1s_cubemap_mips_12.basisu.ktx2");
4343
```
4444

45-
⚠️Note: you have to rename the file extension to `.basisu_ktx2` to load it with this `BasisuLoader`. This is a limitations of bevy because otherwise bevy will load `.ktx2` file with its `ImageLoader`.
45+
⚠️Note: you have to rename the file extension to `.basisu.ktx2` to load it with this `BasisuLoader`. This is a limitations of bevy because otherwise bevy will load `.ktx2` file with its `ImageLoader`.
4646

4747
⚠️Note: The compressed texture dimensions must be a multiplier of block size. See https://github.com/gfx-rs/wgpu/issues/7677 for more context. Also because basisu can transcode to textures with different block size on different platforms,
4848
the texture dimensions should satisfy all possible block sizes. For example, XUASTC 6x6 can transcode to ASTC 6x6 and BC7, so its dimensions should be a multiplier of 12.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 commit comments

Comments
 (0)